Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm-derive: Specify NetworkBehaviour by full path #2932

Merged
merged 5 commits into from Sep 27, 2022

Conversation

folex
Copy link
Contributor

@folex folex commented Sep 22, 2022

Description

Specify NetworkBehaviour as ::libp2p::swarm::NetworkBehaviour in derive.

Links to any relevant issues

#2921

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
Copy link
Member

mxinden commented Sep 22, 2022

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing the patch. I will make sure it makes it into v0.49.0 (#2931).

swarm-derive/src/lib.rs Outdated Show resolved Hide resolved
@mxinden mxinden mentioned this pull request Sep 22, 2022
4 tasks
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this patch.

LGTM modulo the changelog and @mxinden's suggestion!

swarm-derive/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
@folex
Copy link
Contributor Author

folex commented Sep 26, 2022

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

@thomaseizinger
Copy link
Contributor

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

There is a checkbox next to the people that are subscribed to the PR that will allow us to push to this branch only.

@thomaseizinger thomaseizinger changed the title swarm-derive: specify NetworkBehaviour by full path swarm-derive: Specify NetworkBehaviour by full path Sep 27, 2022
@thomaseizinger thomaseizinger changed the title swarm-derive: Specify NetworkBehaviour by full path swarm-derive: Specify NetworkBehaviour by full path Sep 27, 2022
@folex
Copy link
Contributor Author

folex commented Sep 27, 2022

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

There is a checkbox next to the people that are subscribed to the PR that will allow us to push to this branch only.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Seems like that doesn't work with organisations, only with personal forks. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants