Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/worksflows/ci: Fix bad use of bash #2963

Merged
merged 3 commits into from Oct 4, 2022
Merged

Conversation

thomaseizinger
Copy link
Contributor

Description

If only my Bash-fu wouldn't be so bad ...

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger added a commit that referenced this pull request Sep 30, 2022
Otherwise CI will not pass once #2963
actually checks it properly.
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a bit to find the mistake 🕵️

In general, I am open to switching to a better scripting language, e.g. Python, if folks like.

Not that my Python skills are better than my Bash skills. Much rather that I think Python helps me make less mistakes.

@mxinden mxinden merged commit f359c2c into master Oct 4, 2022
@thomaseizinger thomaseizinger deleted the bad-manifest-lint branch October 4, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants