Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core)!: remove EitherError in favor of either::Either #3337

Merged
merged 12 commits into from
Jan 17, 2023
Merged

refactor(core)!: remove EitherError in favor of either::Either #3337

merged 12 commits into from
Jan 17, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Defining our own EitherError type has no value now that Either provides the same implementation.

Related: #3271

Notes

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger mentioned this pull request Jan 17, 2023
Closed
7 tasks
thomaseizinger
thomaseizinger commented Jan 17, 2023
View reviewed changes
core/CHANGELOG.md Outdated Show resolved Hide resolved
jxs
jxs approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

Base automatically changed from no-run-title-as-command to master January 17, 2023 22:13
@mergify mergify bot merged commit f4fed38 into master Jan 17, 2023
@mergify mergify bot deleted the 2650-remove-either-error branch January 17, 2023 23:06
This was referenced Mar 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomaseizinger @jxs