Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(websocket): add WebSocket for WASM environments #4102

Merged
merged 80 commits into from
Oct 10, 2023
Merged

feat(websocket): add WebSocket for WASM environments #4102

merged 80 commits into from
Oct 10, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jun 22, 2023 •
edited

Description

Resolves #3611.

Notes & open questions

This is the continuation of #3679.

Open tasks

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

vincev and others added 30 commits March 26, 2023 16:22
@vincev
Add Websys Websocket transport
fff3b46
@vincev
Add rust version
f3874c7
@vincev
Fix docs test
62ddf7f
@vincev
Fix docs test
3c0069b
@vincev
Include websys feature to full features.
5a86d7c
@vincev
Fix semver error.
50e38e3
@vincev
Fix semver error.
25843d5
@vincev
Don't use libp2p in dev-dependencies
f794aee
@vincev
Add deprecation warning for wasm-ext.
b8503e0
@vincev
Fix clippy error for wasm-ext deprecation
378c03f
@vincev
Merge branch 'libp2p:master' into websys
631dc8b
@vincev
Rename transport package
d5912c5
@vincev
Remove deprecated mplex from doc test
2e4922a
@vincev
Return MultiaddrNotSupported for invalid multi addr.
5534114
@vincev
Use weak pointer in the Websocket callbacks to avoid cycle
d50ea63
@vincev
Set version to 0.1.0 for new package
4603ca6
@vincev
Fix Yamux doc comment
f5b7965
@vincev
Use different wakers for read and write
487828a
@vincev
Use debug_assert for unexpected data format
c688acb
@vincev
Merge branch 'master' into websys
bbdd5fe
@vincev
Make websocket constructor error user friendly.
17e8799
@thomaseizinger
Rewrite style of cargo features
0af2389
@thomaseizinger
Fix spelling of web-sys
4337fc9
@thomaseizinger
Misc clean-up
883552d
@thomaseizinger
use early return
b0b6de8
@thomaseizinger
Refactor booleans to state
27ef99d
@thomaseizinger
Avoid unnecessary wake-ups
0fb9c50
@thomaseizinger
Properly implement poll_close
c3f2abf
@thomaseizinger
Reduce indentation
37cb0cc
@thomaseizinger
Use Vec instead of VecDeque
a30256e
@thomaseizinger
Copy link
Contributor Author

@mxinden With all the WASM and Waker knowledge fresh in my head, I attempted to fix up this PR and I've got passing interop tests locally! It is not critical to merge but if we can get it in before the next breaking release, then we can remove the wasm-ext module! (No more JS in the repo, yeah!)

@mergify

This comment was marked as resolved.

Sign in to view
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger mentioned this pull request Sep 24, 2023
Merged
4 tasks
mxinden
mxinden reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clean. Thank you.

interop-tests/Cargo.toml Show resolved Hide resolved
libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
transports/websocket-websys/src/lib.rs Show resolved Hide resolved
transports/websocket-websys/src/lib.rs Show resolved Hide resolved
transports/websocket-websys/src/lib.rs Outdated Show resolved Hide resolved
@thomaseizinger @mxinden
Apply suggestions from code review
6fc03ae 
Co-authored-by: Max Inden <mail@max-inden.de>
@thomaseizinger thomaseizinger mentioned this pull request Sep 28, 2023
Closed
@mergify

This comment was marked as resolved.

Sign in to view
mxinden
mxinden approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine moving forward as is.

transports/websocket-websys/src/lib.rs Outdated Show resolved Hide resolved
transports/websocket-websys/src/lib.rs Show resolved Hide resolved
@mergify mergify bot merged commit 19c5cf2 into master Oct 10, 2023
73 checks passed
@mergify mergify bot deleted the websys branch October 10, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm-ext: Replace libp2p-wasm-ext with libp2p-websocket-websys
3 participants
@thomaseizinger @mxinden @vincev