Implement ping #42
Merged
Implement ping #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
debris
approved these changes
Nov 24, 2017
mxinden
pushed a commit
to mxinden/rust-libp2p
that referenced
this pull request
Nov 20, 2020
use the score module in the behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
pingprotocol that is specific to IPFS.One point that was discussed is the fact that
ping()returns a tuple of both a pinger and a future that processes incoming messages.The pinger can be used to send pings to the remote, while the future must be used to process pings and respond to pongs. Failing to use the future will just make the whole thing not work. This makes this crate a bit weird to use, but I don't think there is any better solution. Something has to respond to pings that are received by the local node.