Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swarm): don't close connection in OneShotHandler #4715

Merged
merged 9 commits into from Oct 24, 2023
Merged

feat(swarm): don't close connection in OneShotHandler #4715

merged 9 commits into from Oct 24, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

Related: #3591.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added the internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. label Oct 24, 2023
@thomaseizinger
Copy link
Contributor Author

Tagged as internal-change for libp2p-floodsub.

thomaseizinger
thomaseizinger commented Oct 24, 2023
View reviewed changes
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger mentioned this pull request Oct 24, 2023
Closed
mxinden
mxinden approved these changes Oct 24, 2023
View reviewed changes
swarm/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify

This comment was marked as resolved.

Sign in to view
@mergify mergify bot merged commit 7bbca11 into master Oct 24, 2023
71 checks passed
@mergify mergify bot deleted the feat/remove-close-oneshot branch October 24, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomaseizinger @mxinden