feat(quic): enable path mtu discovery #4750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
added a commit
to libp2p/test-plans
that referenced
this pull request
Oct 27, 2023
marten-seemann
approved these changes
Oct 27, 2023
mxinden
changed the title
|
Isn't it enabled by default? Windows has more chances of getting this error and a similar bug was fixed in the opposite direction by @marten-seemann a couple of years ago for go version. IMHO it makes more sense to make it configurable to cover more cases. |
😄 you are right. It is the default since May 6th this year. quinn-rs/quinn#1547
I don't have an opinion on this. Also I would rather have that decision be made in the default implementation of quinn rather than libp2p. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
Fixes #4686
Change checklist