New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use web-time
instead of instant
#5347
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Darius! Only one remark
## 0.17.3 | ||
- Use `web-time` instead of `instant`. | ||
See [PR 5347](https://github.com/libp2p/rust-libp2p/pull/5347). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although libp2p-relay was updated first, I think it would be best to also add an entry for this change for tracking since 0.17.2
was already released. Thoughts @jxs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah makes sense Darius thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also a usage of std::time
in protocols/kad/src/kbucket.rs
and misc/memory-connection-limits/src/lib.rs
that should be replaced with wasm-compatible time implementation. Could you handle those in scope of this PR?
Hi. In |
The issue with |
Nice catch on that! |
sorry for the offtop, but do you happen to know if there is any plan for the release which will include this? Or maybe some backport for 0.53? It crashes our node occasionally and since we're on crates already I'd like to avoid git dependencies |
I can imagine a patch release can be done for majority of the crates here while others like kad may fall under 0.54. A PR could be done to backport the web-time change too |
By the way, I included those without checking if they indeed support wasm, but my thinking is that it doesn't hurt to add it, eventually it may end up being useful and it's probably much easier to maintain if every |
This pull request has merge conflicts. Could you please resolve them @dariusc93? 🙏 |
sorry @dariusc93 can you rebase again one last time? |
This pull request has merge conflicts. Could you please resolve them @dariusc93? 🙏 |
084d75d
to
580fae1
Compare
Hmm Im not sure what is causing the transport interoperability test to continue to fail (been that way since upgrading to web-time). Could be that |
yeah seems to be failing, did you see https://github.com/libp2p/rust-libp2p/actions/runs/9191874572/job/25279212100?pr=5347#step:5:1133 seems to not be able to connect |
Will this be included in the release? About the connection failure: Can you check if this is happening if you revert into specifying Chrome's version? |
Description
See sebcrozet/instant#52
Notes & open questions
Change checklist