Use upstream rust-secp256k1 #616
Conversation
|
Anyone looked into https://docs.rs/libsecp256k1/0.1.14/secp256k1/ ? I have not done so yet. |
|
We need to make sure either that this doesn't break substrate, or that substrate can be upgraded as well. |
|
The original reason to fork is this issue: bitcoin-core/secp256k1#352 If libp2p does not need to support ECDH with anything else other than SHA256, or it does not use ECDH in the first place, then it's fine to use upstream I would guess. |
|
We're not using ECDH with secp256k1. |
|
Substrate compiles and tests run green. |
…e-handled_node_tasks * upstream/master: Tweaks, spelling and grammar (libp2p#629) Add a badge with a link to deps.rs (libp2p#630) Rewrite floodsub to use the ProtocolsHandler (libp2p#603) Add an IdentifyListen behaviour (libp2p#626) Add a custom derive for NetworkBehaviour (libp2p#619) Set the maximum size of Mplex messages to 1Mb (libp2p#622) Use expect rather than unwrap (libp2p#625) Make libp2p-websocket optional (libp2p#624) Add From<IpAddr> for Multiaddr (libp2p#623) Add implementations of NetworkBehaviour for ping (libp2p#618) Add a PeriodicIdentifyBehaviour (libp2p#617) Use upstream rust-secp256k1 (libp2p#616) Use yamux and aio-limited from crates.io (libp2p#621)
…st-collection_stream * dp/chore/test-core-handled_node_tasks: (24 commits) Revert changes to Debug impl for HandledNodesTasks whitespace Don't organise tests in submodules Rename test builders Tweaks, spelling and grammar (libp2p#629) Add a badge with a link to deps.rs (libp2p#630) Rewrite floodsub to use the ProtocolsHandler (libp2p#603) Add an IdentifyListen behaviour (libp2p#626) Add a custom derive for NetworkBehaviour (libp2p#619) Set the maximum size of Mplex messages to 1Mb (libp2p#622) Use expect rather than unwrap (libp2p#625) Make libp2p-websocket optional (libp2p#624) Add From<IpAddr> for Multiaddr (libp2p#623) Add implementations of NetworkBehaviour for ping (libp2p#618) Add a PeriodicIdentifyBehaviour (libp2p#617) Use upstream rust-secp256k1 (libp2p#616) Use yamux and aio-limited from crates.io (libp2p#621) Remove tests for Task we don't need Test Task.send_event() and id() using a HandledNodesTasks Better debug impl for HandledNodesTasks Address grumbles ...
@burdges I did, briefly, and spoke to the author. It is incomplete atm so it'd require some work to extend the API to work for secio, it is not audited and has not seen production use. It is definitely an interesting lib and over time might become a good replacement candidate but in its current state we can't use it. |
The question implied here is: why did we fork
rust-secp256k1and are those reasons still valid? Can we get back to the mainline crate? There is ongoing work on our fork to make itno_stdbut I'm not sure what the end-goal of that effort is.Part of #593