Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document smart dialing and black hole detection #559

Open
marten-seemann opened this issue Jul 14, 2023 · 1 comment
Open

document smart dialing and black hole detection #559

marten-seemann opened this issue Jul 14, 2023 · 1 comment

Comments

@marten-seemann
Copy link
Contributor

It would be great if we could write up the logic that go-libp2p uses, so other implementations can easily implement something similar. This is mostly non-normative, although we could say something like “An implementation MUST NOT dial more than 4 (?) addresses in parallel.”

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Jul 20, 2023

I'd be in favor of a place where different implementations can collaborate and document, how they did things and what seems to be working well / not so well.

Almost like an implementation guide.

Another interesting topic would be the "address pipeline". Even though implementations are obviously free to do what they want, I think we could save some effort by documenting the thought process. For example, in rust-libp2p, we ended making a system where every module can emit external address candidates which can then be picked up by something like autonat to go and verify and emit confirmed external addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants