Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update module path #6

Merged
merged 3 commits into from
Aug 12, 2021
Merged

update module path #6

merged 3 commits into from
Aug 12, 2021

Conversation

marten-seemann
Copy link

No description provided.

Stebalien
Stebalien approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an attribution comment pointing upstream?

@marten-seemann
Copy link
Author

This is not enough?
image
Or were you thinking of an explanation why we created this fork?

@Stebalien
Copy link
Member

Or were you thinking of an explanation why we created this fork?

Yeah. I'd kind of like a small blurb just to explain.

@Stebalien
Copy link
Member

(not critical, but nice to do)

@marten-seemann
Copy link
Author

Will do in a separate PR.

@marten-seemann marten-seemann merged commit bc7f7c7 into master Aug 12, 2021
@marten-seemann marten-seemann deleted the update-module-path branch August 12, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marten-seemann @Stebalien