Move calls to Initialize above Timeout token #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, as discovered in #327, when using ReadAsync or WriteAsync without first making a call to InitializeAsync and the initialization fails - the exception thrown is of type TaskCancelledException - not LibplctagException.
If I recall correctly, the intention was to throw a LibplctagException for the libplctag.NET async timeouts, and only to throw a TaskCancelledException if the supplied token is cancelled,
One issue with the attached patch is that there is now two separate timeouts - one for the Initialization, and a second one for the Read - so if there is a 10 second timeout, and a 9 second latency on operations - it will successfully complete in 2*9seconds=18seconds -> maybe the library consumer is expected it to timeout because 18 seconds is larger than the configured timeout.
Either way, this is an API-breaking change so will require some sort of version bump.