Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable #[no_std] use by providing std feature #562

Merged
merged 1 commit into from May 12, 2022
Merged

Conversation

Felix-El
Copy link
Contributor

@Felix-El Felix-El commented Apr 28, 2022

Also adds a dependency on no_std_net for no_std addresses.

#133

Adds a dependency on no_std_net for no_std addresses
@mrmonday
Copy link
Contributor

@mrmonday mrmonday commented May 12, 2022

This looks great - thanks!

It would be good to have nostd tested in CI so this doesn't regress, but that can be done in another PR later on.

@mrmonday mrmonday merged commit 9e06711 into libpnet:master May 12, 2022
3 checks passed
@fujiapple852
Copy link

@fujiapple852 fujiapple852 commented May 24, 2022

@mrmonday @Felix-El this change has bumped the effective MSRV to 1.60 due to the use of the new dep-name?/feature-name Cargo syntax, specifically this change.

Was this intended?

@Felix-El
Copy link
Contributor Author

@Felix-El Felix-El commented May 24, 2022

I'm open to using a pre-1.60 Cargo syntax. I'm just not aware of it. Is there an alternative syntax for requesting a feature conditionally without forcing the dependency in?

@fujiapple852
Copy link

@fujiapple852 fujiapple852 commented May 24, 2022

@Felix-El I'm not completely sure, the original GH RFC suggests "There exists a kind of workaround" which doesn't inspire confidence!

No issue with bumping the MSRV from time to time, it may be useful to add the conventional rust-version attribute to Cargo.toml and mention bumps prominently in release notes and the README to save people having to figure it out.

@mrmonday
Copy link
Contributor

@mrmonday mrmonday commented May 24, 2022

We used to support older Rust versions - we changed at some point to only support the latest stable Rust.

This said, I'm happy to accept a PR to make these changes place nicely with older Rust versions if that's possible.

@Felix-El Felix-El mentioned this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants