CL compiler compat #105
Merged
CL compiler compat #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jschueller
commented
Oct 26, 2023
•
jschueller
commented
- Drop remaining use of vlas in tests
- Add CI tests for MS C compiler in combinations with intel fortran compilers.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jschueller
force-pushed
the
msvc
branch
8 times, most recently
from
1ca2a00
to
4185c2a
Compare
|
Hi Julien @jschueller , thank you for the very prompt response, as always. Since this PR is only about tests and all of them pass, I can merge it when you think it is ready. Thanks! |
zaikunzhang
reviewed
Oct 26, 2023
|
it should be ok to merge when CI is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.