Add (broken) cii experiment #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo * fix pg query syntax * double check render
|
@andrew would be good to understand what's happening with the db qry here. Tripping up on |
andrew
reviewed
Apr 28, 2017
app/models/project.rb
Outdated
| scope :digital_infrastructure, -> { not_removed | ||
| .with_dependent_repos | ||
| .with_repo | ||
| .where('projects.dependent_repos_count DESC NULLS LAST').limit(1000)} |
There was a problem hiding this comment.
This should be .order, rather than .where at the start of this line
| def unseen_infrastructure | ||
| orginal_scope = Project.unsung_heroes | ||
| scope = current_platform.present? ? orginal_scope.platform(current_platform) : orginal_scope | ||
| @projects = scope.order('projects.dependent_repos_count DESC').paginate(page: page_number) | ||
| @platforms = orginal_scope.group('projects.platform').count.reject{|k,_v| k.blank? }.sort_by{|_k,v| v }.reverse.first(20) | ||
| @platforms = orginal_scope.group('projects.platform').count.reject{|k,_v|÷ k.blank? }.sort_by{|_k,v| v }.reverse.first(20) | ||
| end |
There was a problem hiding this comment.
Weird percentage symbol on this line that needs to be removed
|
Tak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo