bumb gitlab API version #1684
Merged
bumb gitlab API version #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, an example of a gitlab-hosted repo is https://libraries.io/rubygems/gitaly. I'll try and get that ruby gem. |
|
I tested on that repo and navigating to the gitlab url works, so I this may be good to go. |
|
Looks good, thanks @e-beach! |
andrew
added a commit
that referenced
this pull request
Sep 12, 2017
* master: (26 commits) Add concurrent-ruby-ext gem to speed up sidekiq Update appsignal Updated capistrano version lock Updated rails to 5.0.6 Update dependencies Update README.md Update docs to reflect that watcher is now dispatch Fix typo Update pictogram with latest puppet logo Update counter_culture, fixes #1690 Update dependencies Show all licenses in some places, fixes #1678 Improve docs around running a background worker Handle download_members being called on github users gracefully bumb gitlab API version (#1684) Update dependencies Don't strip booleans Update brakeman Support markdown readmes for gitlab and bitbucket Fix double escaping issues with gitlab api ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1658.
I'm not sure what level of testing is needed - the ruby tests pass, but as for verifying if the site actually works I'm not sure what to do.
Two questions: