Update button copy for subscribed projects #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change to read "Already subscribed" - Fixes #1752
|
Thanks! |
andrew
added a commit
that referenced
this pull request
Nov 24, 2017
* master: (114 commits) Handle repos with nil avatars Update bugsnag Update button copy for subscribed projects (#1827) Revert "Disable test for issue/pull request events from GH" (#1837) Stub jam package manager project method Show warning in header when in read-only mode Cap command to restart only web servers Rollback premailer-rails update Disable rake tasks when in READ_ONLY mode Update dependencies Change enable_private link in notice email Hook up opt-in link in notice email Notice email content and mailer preview Update terms Update privacy policy Add footer hr back in Swap png for svg Scaffolding for Tidelift notice email Replace BNS logo in footer with Tidelift Remove safestack logo ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines for contributors?
Have you checked to ensure there aren't other open pull requests on the repository for a similar change?
Is there a corresponding ticket for your pull request?
Have you written new tests for your changes?
Have you successfully run the project with your changes locally?
Fixes UX Suggestion "Subscribe to releases" button #1752
This change adds a checkmark to the "subscribe" button and updates the copy to read "Already subscribed" when a user is viewing a project they are subscribed to. As mentioned in the issue, this more clearly differentiates between the two states.
Please note that this removes the conditional that would show the word "stable." Also, the Bootstrap grid widths were adjusted to accommodate the larger button size.