Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces BulkVersionUpdater to fix Version read/write N+1s in PackageManager::Base #3268

Closed
wants to merge 9 commits into from
Closed

Introduces BulkVersionUpdater to fix Version read/write N+1s in PackageManager::Base #3268

wants to merge 9 commits into from

Commits on Jan 30, 2024

  1. Replace VersionUpdater with a bulk upsert_all to avoid N+1s.

    @tiegz
    tiegz committed Jan 30, 2024
    Copy the full SHA
    b64759d View commit details
    Browse the repository at this point in the history

  2. We can remove Version uniq validation bc a uniq index exists.

    @tiegz
    tiegz committed Jan 30, 2024
    Copy the full SHA
    c77b558 View commit details
    Browse the repository at this point in the history

  3. Insert callbacks that would have been called on each version.

    @tiegz
    tiegz committed Jan 30, 2024
    Copy the full SHA
    594b28e View commit details
    Browse the repository at this point in the history

  4. Extract upsert_all code into a BulkVersionUpdater and start specs.

    @tiegz
    tiegz committed Jan 30, 2024
    Copy the full SHA
    f632e26 View commit details
    Browse the repository at this point in the history

  5. Ensure we update proper attributes

    @tiegz
    tiegz committed Jan 30, 2024
    Copy the full SHA
    cb6e7dd View commit details
    Browse the repository at this point in the history

  6. Note that we are touching updated_at on records even if they didnt' c… 

    …hange.
    @tiegz
    tiegz committed Jan 30, 2024
    Copy the full SHA
    6250006 View commit details
    Browse the repository at this point in the history

  7. Google updater fixes after rebase from main.

    @tiegz
    tiegz committed Jan 30, 2024
    Copy the full SHA
    5c13a48 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Add a note about a possible optimization.

    @tiegz
    tiegz committed Feb 1, 2024
    Copy the full SHA
    db1d872 View commit details
    Browse the repository at this point in the history

  2. Better name for update_spdx_expression = set_spdx_expression.

    @tiegz
    tiegz committed Feb 1, 2024
    Copy the full SHA
    8eea0c3 View commit details
    Browse the repository at this point in the history