Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose lesson to regular expressions, move intro, jargon, foundations to overview #146

Closed
6 tasks
libcce opened this issue Sep 6, 2019 · 13 comments
Closed
6 tasks
Assignees

Comments

@libcce
Copy link
Contributor

libcce commented Sep 6, 2019

@libcce
Copy link
Contributor Author

libcce commented Sep 6, 2019

@antonangelo you are still not listed as a Maintainer (in the team site) for this lesson. Can you check to see if you got a message from GitHub asking you to join the lesson team?

@ccronje
Copy link
Contributor

ccronje commented Sep 7, 2019

Thanks for all this hard work @libcce! I've reviewed the Workshop Overview and agree with the list above. Thanks for updating the lesson listing also.

@libcce
Copy link
Contributor Author

libcce commented Sep 7, 2019

There was one thing that I couldn't figure out, why the link to the intro to LC was not working. We may need to reorder the episodes as well?

@libcce
Copy link
Contributor Author

libcce commented Sep 7, 2019

We will also have to figure who the maintainers of the overview will be. Do some of split off to maintain the regex lesson and some of us split off to maintain the overview? For now, I just moved the intro to data maintainers to overview.

@ccronje
Copy link
Contributor

ccronje commented Sep 7, 2019

@libcce https://github.com/LibraryCarpentry/lc-overview/blob/gh-pages/_episodes/02-intro-to-library-carpentry.md doesn't have a header section - that may be the problem?

Do you have a particular concern about the order of the episodes? If yes, let's ping lc-data-intro-maintainers.

Good idea moving the lc-data-intro-maintainers to the overview. Let's check with the group on teams for volunteers for the regex lesson. Is it time to put a call out to the LC community to invite new maintainers and/or relieve current folks?

@libcce
Copy link
Contributor Author

libcce commented Sep 7, 2019

@ccronje it’s funny I just added a header. Looks like it’s working now.

I did wonder if the episode order was fine so having additional feedback would be good.

Would be great to hear from the others about how we manage the Maintainers on the two lessons now.

@ccronje
Copy link
Contributor

ccronje commented Sep 7, 2019

@libcce excellent :-) I'll start a discussion thread in lc-data-intro-maintainers

@ccronje
Copy link
Contributor

ccronje commented Sep 8, 2019

Tasks left to do on this issue:

  • Delete Intro to LC from Intro to Data
  • Delete Foundations from Intro to Data
  • Delete Jargon Busting from Intro to Data
  • Split Regular Expressions episode in Intro to Data into two episodes (new episode will start at Exercise Using Regex101.com)
  • Update episode numbers and headers in Intro to Data
  • Rename Intro to Data lesson to Regular Expressions
  • Update links impacted by lesson name change (will need to check lessons' setup pages, README files, LC website) << lesson name changes have been problematic in the past, is there a checklist?

libcce pushed a commit that referenced this issue Sep 19, 2019
@libcce
Copy link
Contributor Author

libcce commented Sep 19, 2019

Removed intro to LC #149

libcce pushed a commit that referenced this issue Sep 19, 2019
@libcce
Copy link
Contributor Author

libcce commented Sep 19, 2019

Remove foundations #150

libcce pushed a commit that referenced this issue Sep 19, 2019
@libcce
Copy link
Contributor Author

libcce commented Sep 19, 2019

Remove jargon busting #151

@libcce
Copy link
Contributor Author

libcce commented Sep 19, 2019

Hi @ccronje @sharilaster @ppival @antonangelo all the changes have been addressed but for the moment I've kept the current repo name so that we don't have some of the linking issues pointed out by @ccronje. One other thing we forgot was updating the extra pages which I've done. Also, I've created a callout on the lesson overview page which talks about how regex is taught. If you like what you see, thumbs up this comment and we can close the issue. I do think there is still work to be done on the lesson content and the times may need to be adjusted but these can be issues/PRs as time goes by, as we catch things.

@ccronje
Copy link
Contributor

ccronje commented Nov 9, 2019

Thanks @libcce!

@ccronje ccronje closed this as completed Nov 9, 2019
zkamvar pushed a commit that referenced this issue May 3, 2023
zkamvar pushed a commit that referenced this issue May 3, 2023
zkamvar pushed a commit that referenced this issue May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants