Delegate newtype EOC (#163)

* making newtype delegation work for complex inner types * comment the test
librasn · Sep 28, 2023 · aea08d0 · aea08d0
1 parent f4e692b
commit aea08d0
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 11 deletions.
diff --git a/macros/src/decode.rs b/macros/src/decode.rs
@@ -27,11 +27,18 @@ pub fn derive_struct_impl(
             }
         } else {
             quote! {
-                <#ty as #crate_root::Decode>::decode_with_tag_and_constraints(
-                    decoder,
-                    tag,
-                    <#ty as #crate_root::AsnType>::CONSTRAINTS.override_constraints(constraints),
-                ).map(Self)
+                match tag {
+                    #crate_root::Tag::EOC => {
+                        Ok(Self(<#ty>::decode(decoder)?))
+                    }
+                    _ => {
+                        <#ty as #crate_root::Decode>::decode_with_tag_and_constraints(
+                            decoder,
+                            tag,
+                            <#ty as #crate_root::AsnType>::CONSTRAINTS.override_constraints(constraints),
+                        ).map(Self)
+                    }
+                }
             }
         }
     } else if config.set {

diff --git a/macros/src/encode.rs b/macros/src/encode.rs
@@ -35,12 +35,19 @@ pub fn derive_struct_impl(
             }
         } else {
             quote!(
-                <#ty as #crate_root::Encode>::encode_with_tag_and_constraints(
-                    &self.0,
-                    encoder,
-                    tag,
-                    <#ty as #crate_root::AsnType>::CONSTRAINTS.override_constraints(constraints)
-                )
+                match tag {
+                    #crate_root::Tag::EOC => {
+                        self.0.encode(encoder)
+                    }
+                    _ => {
+                        <#ty as #crate_root::Encode>::encode_with_tag_and_constraints(
+                            &self.0,
+                            encoder,
+                            tag,
+                            <#ty as #crate_root::AsnType>::CONSTRAINTS.override_constraints(constraints)
+                        )
+                    }
+                }
             )
         }
     } else {

diff --git a/tests/derive.rs b/tests/derive.rs
@@ -151,6 +151,33 @@ pub struct BasicConstraints {
     pub path_len_constraint: Option<Integer>,
 }
 
+// This test makes sure that Newtype3(Newtype2(Newtype1(T))) results in serializing
+// as T when using the #[rasn(delegate)] attribute when T is a non-universal type.
+#[test]
+fn delegated_newtype_wrapping() {
+    #[derive(AsnType, Debug, Decode, Encode, PartialEq)]
+    #[rasn(choice)]
+    enum Hash {
+        #[rasn(tag(explicit(0)))]
+        Sha256(String),
+    }
+
+    #[derive(AsnType, Debug, Decode, Encode, PartialEq)]
+    #[rasn(delegate)]
+    struct TransactionID(Hash);
+
+    #[derive(AsnType, Debug, Decode, Encode, PartialEq)]
+    #[rasn(delegate)]
+    struct PolicyID(TransactionID);
+
+    let policy_id1 = PolicyID(TransactionID(Hash::Sha256("abcdef".into())));
+
+    let ser = rasn::der::encode(&policy_id1).unwrap();
+    assert_eq!(&ser[..], &[160, 8, 12, 6, 97, 98, 99, 100, 101, 102]);
+    let policy_id2: PolicyID = rasn::der::decode(&ser[..]).unwrap();
+    assert_eq!(policy_id1, policy_id2);
+}
+
 // This test will fail to compile if `Result` is used in the derive/proc macros instead of
 // `core::result::Result`
 #[test]