Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
I think this should be sufficient for my use case, however I did have a question. I originally had a
new_set_with_buffer
but asself.output()
doesn't actually use theself.output
for the final encoding whenis_set_encoding: true
and ismem::take(&mut self.output)
'd elsewhere, I felt like it would be pretty useless since the whole point is to allow reusing the buffer space for the final encoding, but this does kind of expose this implementation detail and could cause some confusion since there's a missing function, not entirely sure what a good solution is for this.Let me know if there's anything else you'd like adjusted.