Field_error improved, Boxed error kind, explicit naming also for DecodeErrorKind
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! I'm unsure about making the backtrace optional. Since I'm not sure this is less complex than fixing the decode_sequence_of and decode_set_of |
|
I was also thinking cases if someone builds logic for 'Incomplete' errors, not just the internal handling. But I can try to find another solution. |
Nicceboy
changed the title
kind, explicit naming
|
I reverted the optional backtrace, maybe it is better to check other changes first |
Nicceboy
changed the title
kind, explicit namingkind, explicit naming
Nicceboy
changed the title
kind, explicit namingkind, explicit naming also for DecodeErrorKind
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boxed
Kindtype for error variants.Also some other error improvements.
Parser errors fromIncompleteandMismatchedTagdoes not include backtrace anymore.Should restore the performance.