fix(jer): ENUMERATED values as strings #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! Turns out I've been looking at the wrong spec for the JER implementation 😑, meaning that the entire |
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
|
@6d7a, I don't know which spec you were looking at, but it looks to me that it is pretty close to X.697 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
The JER standard (X.697 22. 2021) mandates that JER-encoded ENUMERATED values must be JSON strings instead of integers.
First PR here, so let me know if it can be improved in any way, thanks!