Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backtraces from rasn's default feature #247

Merged
merged 2 commits into from May 8, 2024

Conversation

s-arash
Copy link
Contributor

@s-arash s-arash commented Apr 30, 2024

This feature can incur a significant performance penalty, and since it's more of a debugging tool, it should be disabled by default.

In my experiments, there was a ~15x perf improvement when decoding OCSP responses with this feature disabled.

Closes #246

@XAMPPRocky
Copy link
Collaborator

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 9476bae into librasn:main May 8, 2024
65 checks passed
@github-actions github-actions bot mentioned this pull request May 8, 2024
@s-arash
Copy link
Contributor Author

s-arash commented May 8, 2024

Thanks @XAMPPRocky!

@s-arash
Copy link
Contributor Author

s-arash commented May 8, 2024

@XAMPPRocky Any estimates of when we'll have a new release?

This was referenced May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standards crates (rasn-pkix, rasn-ocsp, etc.) should not enable rasn's default feature
2 participants