Modify Attribute, RelativeDistinguishedName and add AttributeTypeAndValue to match RFCs

[curtisleefulton]

Pull request modifies Attribute, RelativeDistinguishedName and adds AttributeTypeAndValue to match RFCs, as detailed below.

1. Update Attribute

Change value to values; use SetOf<AttributeValue> instead of AttributeValue.

Defined in module PKIX1Explicit88 (https://www.itu.int/wftp3/Public/t/fl/ietf/rfc/rfc3280/PKIX1Explicit88.html)

Attribute               ::= SEQUENCE {
      type             AttributeType,
      values    SET OF AttributeValue }
            -- at least one value is required
            
AttributeType           ::= OBJECT IDENTIFIER     

AttributeValue          ::= ANY -- DEFINED BY AttributeType       

Also defined in RFC 5652 (https://www.ietf.org/rfc/rfc5652)

Attribute ::= SEQUENCE {
        attrType OBJECT IDENTIFIER,
        attrValues SET OF AttributeValue }
        
AttributeValue ::= ANY        

Attribute uses in Rasn:

AttributeCertificateInfo from RFC 5755 (https://www.ietf.org/rfc/rfc5755)

   AttributeCertificateInfo ::= SEQUENCE {
          -- clipped
          attributes              SEQUENCE OF Attribute, 
          -- clipped      
        }

ACClearAttrs (AttributeCertificateClearAttributes) from RFC 5755 (https://www.ietf.org/rfc/rfc5755)

 ACClearAttrs ::= SEQUENCE {
     acIssuer  GeneralName,
     acSerial  INTEGER,
     attrs     SEQUENCE OF Attribute
   }

SubjectDirectoryAttributes from RFC 5280 (https://www.ietf.org/rfc/rfc5280)

SubjectDirectoryAttributes ::= SEQUENCE SIZE (1..MAX) OF Attribute

Five sets from RFC 5652 (https://www.ietf.org/rfc/rfc5652):

• SignedAttributes
• UnsignedAttributes
• UnprotectedAttributes
• AuthAttributes
• UnauthAttributes

SignedAttributes ::= SET SIZE (1..MAX) OF Attribute

UnsignedAttributes ::= SET SIZE (1..MAX) OF Attribute

UnprotectedAttributes ::= SET SIZE (1..MAX) OF Attribute

AuthAttributes ::= SET SIZE (1..MAX) OF Attribute

UnauthAttributes ::= SET SIZE (1..MAX) OF Attribute

2. Add AttributeTypeAndValue

Defined in module PKIX1Explicit88 (https://www.itu.int/wftp3/Public/t/fl/ietf/rfc/rfc3280/PKIX1Explicit88.html).

AttributeTypeAndValue   ::= SEQUENCE {
        type    AttributeType,
        value   AttributeValue }

3. Update RelativeDistinguishedName

Change collection type from Attribute to AttributeTypeAndValue

RelativeDistinguishedName from RFC 5280 (https://www.ietf.org/rfc/rfc5280):

RelativeDistinguishedName ::= SET SIZE (1..MAX) OF AttributeTypeAndValue

[repnop]

(might want to adjust the PR title!)

[XAMPPRocky]

Thank you for your PR! This looks good to me, but there are changes mentioned in the post that im not seeing in the code changes, is that intentional?

[curtisleefulton]

There are no integration tests for Attribute use cases (aside from RelativeDistinguishedName, which now uses AttributeTypeAndValue), so the change is a little invisible. However, the PR is a breaking change for Attribute, so I listed all the places Attribute is used in Rasn/standards. I also verified that the linked RFCs all need the modified Attribute. Anyone using those types will need to update their code.

…

-CLF

On Thu, Mar 17, 2022 at 11:04 AM XAMPPRocky ***@***.***> wrote: Thank you for your PR! This looks good to me, but there are changes mentioned in the post that im not seeing in the code changes, is that intentional? — Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZ6XR4QDZYZEHRTPABW7FLVANX2RANCNFSM5Q5YJVMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[XAMPPRocky]

Alright sounds good to me, thanks for being so through. I'll release a minor version within the next day or so. Thank you for your PR, and congrats on your first contribution! 🎉

[curtisleefulton]

Thank you!