Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database Server: Drop requirement for database setting #42

Closed
sgallagher opened this issue Sep 1, 2015 · 0 comments
Closed

Database Server: Drop requirement for database setting #42

sgallagher opened this issue Sep 1, 2015 · 0 comments
Assignees
@sgallagher
Labels
enhancement In Progress Under Review
Milestone
Fedora 23 Beta

Comments

@sgallagher
Copy link
Contributor

The only mandatory argument for the Database Server role is the name of the database. It would make more sense to simply take the role instance name instead of forcing a settings-file.

We should take the instance name or, in the case of autogenerated instances, prefix it with db_.
@sgallagher sgallagher self-assigned this Sep 1, 2015
@sgallagher sgallagher added this to the Fedora 23 Beta milestone Sep 1, 2015
sgallagher added a commit to sgallagher/rolekit that referenced this issue Sep 1, 2015
@sgallagher
Database Server: Drop requirement for database name
5ba5f11 
Don't require that we submit the DB name as a separate argument. We
can take the role instance name if no DB name was specified.

If the DB name starts with a non-alphabetic character, prefix it
with `db_`

Fixes libre-server/rolekit#42
sgallagher added a commit to sgallagher/rolekit that referenced this issue Sep 1, 2015
@sgallagher
Database Server: Drop requirement for database name
a5aeb2d 
Don't require that we submit the DB name as a separate argument. We
can take the role instance name if no DB name was specified.

If the DB name starts with a non-alphabetic character, prefix it
with `db_`

Fixes libre-server/rolekit#42
sgallagher added a commit to sgallagher/rolekit that referenced this issue Sep 1, 2015
@sgallagher
Database Server: Drop requirement for database name
6272610 
Don't require that we submit the DB name as a separate argument. We
can take the role instance name if no DB name was specified.

If the DB name starts with a non-alphabetic character, prefix it
with `db_`

Fixes libre-server/rolekit#42
sgallagher added a commit to sgallagher/rolekit that referenced this issue Sep 1, 2015
@sgallagher
Database Server: Drop requirement for database name
4e0b1e9 
Don't require that we submit the DB name as a separate argument. We
can take the role instance name if no DB name was specified.

If the DB name starts with a non-alphabetic character, prefix it
with `db_`

Fixes libre-server/rolekit#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgallagher sgallagher

Labels
enhancement In Progress Under Review
Projects
None yet
Milestone
Fedora 23 Beta
Development

No branches or pull requests
1 participant
@sgallagher