Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly parse date strings #4924

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: Properly parse date strings #4924

merged 2 commits into from
Oct 18, 2023

Conversation

Isira-Seneviratne
Copy link
Collaborator

Properly parse the new date format, which contains a time offset.

@IndusAryan
Copy link
Contributor

today when i created a branch to work on the instance button issue, i merged this and app is crashing with same datetimeparse errors, but the current alpha with new dates is working fine!

@Isira-Seneviratne
Copy link
Collaborator Author

Isira-Seneviratne commented Oct 8, 2023 •
edited

today when i created a branch to work on the instance button issue, i merged this and app is crashing with same datetimeparse errors, but the current alpha with new dates is working fine!

What's the date format displayed in the error message?

Update: I made a few more changes, there should be no issues now.

@IndusAryan
Copy link
Contributor

yes, it's perfect now.

@Bnyro
Copy link
Member

Bnyro commented Oct 10, 2023

We currently still only use the date without time. Wouldn't it make more sense to use Instant for everything (so that hours, minutes and seconds are taking into consideration too) and parse LocalDate instances to an Instant at 00:00 instead?

@Isira-Seneviratne
Copy link
Collaborator Author

We currently still only use the date without time. Wouldn't it make more sense to use Instant for everything (so that hours, minutes and seconds are taking into consideration too) and parse LocalDate instances to an Instant at 00:00 instead?

Yeah, it would.

@Isira-Seneviratne Isira-Seneviratne force-pushed the Fix_date_parse branch 3 times, most recently from 223bd87 to 1c8e5c5 Compare October 18, 2023 01:11
@Isira-Seneviratne Isira-Seneviratne merged commit b17719f into libre-tube:master Oct 18, 2023
4 checks passed
@Isira-Seneviratne Isira-Seneviratne deleted the Fix_date_parse branch October 18, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Isira-Seneviratne @IndusAryan @Bnyro