feat: landscape layout for player page #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
added
help wanted
Bnyro
changed the title
3 tasks
|
When I open Settings Libretube launches in portrait mode first and then rotate to landscape mode. Tested on Android 9. |
Bnyro
changed the title
|
Hi. The tiling might not be working out as you planned it. This is from your debug build from today, from a Samsung Galaxy Tab S5e (Android 11). Ignore the slightly off aspect ratio, it looks normal, I just chose a terrible method of screenshotting Neverthless thank you for an amazing app, and thank you for working on this.
|
|
Hmm, do you have related streams disabled? |
|
Oh, I can reproduce the issue now. Seems like this was introduced a few commits ago, it did work pretty well when I merged this PR. Please open an issue so that we don't forget to fix this before the next release. |
|
Opened #5131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3198