Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subtitles not displayed offline #5004

Merged
merged 3 commits into from
Oct 19, 2023
Merged

fix: subtitles not displayed offline #5004

merged 3 commits into from
Oct 19, 2023

Conversation

janisslsm
Copy link
Contributor

fixes #1700

@janisslsm janisslsm marked this pull request as draft October 18, 2023 19:34
@janisslsm janisslsm marked this pull request as ready for review October 18, 2023 20:56
@janisslsm janisslsm changed the title fix: empty subtitles when downloaded fix: subtitles not displayed offline Oct 18, 2023
Bnyro
Bnyro approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bnyro Bnyro merged commit 39d52ff into libre-tube:master Oct 19, 2023
4 checks passed
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bnyro Bnyro Bnyro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Downloaded subtitles can't be played.
2 participants
@janisslsm @Bnyro