fix: auto fullscreen stops working after first rotation #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having problems with ktlint and I can't run it locally to be sure it's ok, I suggest to use detekt with maybe git hooks to run it in pre-commit or pre-push |
|
Please run |
Bnyro
force-pushed
the
auto-fullscreen-bug
branch
from
73e03bd
to
98dc929
Compare
Bnyro
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix orientation bug where screen get stuck after first orientation change.
Bug was in an if that where removing
SCREEN_ORIENTATION_SENSORfrommainActivity.requestedOrientationignoring autoFullscreenEnabled prefs.I'm not sure if I've done some regression on other things as I don't know yet all the app behaviours, every suggestion is welcome.