fix: Increase subtitle font size in fullscreen #5200
Conversation
| val fullscreenCaptionsTextSize: Float | ||
| get() = PreferenceHelper.getString( | ||
| PreferenceKeys.CAPTIONS_SIZE, | ||
| "27" | ||
| ).toFloat() |
There was a problem hiding this comment.
You didn't add a preference for that yet, so the user can't change it. And I think we should just make the font size 1.5 times bigger in landscape than usually instead of adding a new preference.
|
I think we should just make the font size 1.5 times bigger in landscape than usually instead of adding a new preference. |
| @@ -695,11 +695,19 @@ open class CustomExoPlayerView( | |||
| if (PlayerHelper.swipeGestureEnabled && this::brightnessHelper.isInitialized) { | |||
There was a problem hiding this comment.
Due to this line this will only be executed when swipe gestures are enabled.
Please move this condition around the brightnessHelper.restoreSavedBrightness() calls below to fix this.
Otherwise lgtm.
There was a problem hiding this comment.
Yes, exactly. Please do the same in the else block where brightnessHelper.resetToSystemBrightness() is called, then we're good to merge this 👍
| if (isFullscreen) { | ||
| if (PlayerHelper.swipeGestureEnabled && this::brightnessHelper.isInitialized) { | ||
| brightnessHelper.restoreSavedBrightness() |
Bnyro
force-pushed
the
saymanrifat-5095-subtitle-optz
branch
from
5155965
to
05e9bf2
Compare
#5095 fix: Increase subtitle font size in fullscreen