Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make setting's descriptions more consistent #5378

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

RafaelsRamos
Copy link
Contributor

This PR:

  • Removes a few unused translations;
  • Removes final periods from settings descriptions (in all languages);
  • Changes only English translation of disable_proxy_summary from "Load videos and images directly from YouTube's servers. Only enable the option if you use a VPN anyways!" to "Load videos and images directly from YouTube's servers. Only enable the option if you always use a VPN".

Sample

Sample.mp4

Notes:

  • Pay special attention to the Sample.mp4 at the 11th second mark. As you can see, the descriptions are very large and contain a period in the middle - making it a complex sentence. Usually, these descriptions are simple, so I suggest we take this into consideration for future settings.
  • I removed all periods in the end due to the points mentioned at Inconsistency in settings descriptions #5377. Please let me know if you disagree with this approach.

closes #5377

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look into that.

That's really one of the things I've already wanted to look into some time ago but I've just been too lazy to spend time with it :)

@Bnyro Bnyro merged commit c7e9b9d into libre-tube:master Dec 22, 2023
3 of 4 checks passed
@RafaelsRamos RafaelsRamos deleted the fix/5377 branch January 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in settings descriptions
2 participants