Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: tweak speed/pitch bottom sheet layout #5434

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

RafaelsRamos
Copy link
Contributor

@RafaelsRamos RafaelsRamos commented Jan 4, 2024

  • Improve layout of video/audio speed sheet;
  • Add tools:listitem="@layout/slider_label_item"to recyclerviews, to improve preview;

Please let me know if you think this change didn't result in an improvement.

Before

behaviour_before.mp4

Now

behaviour_after.mp4

Side by Side (Before - in the Left, Now - in the right)

@Bnyro Bnyro changed the title Tweak speed/pitch bottom sheet layout style: tweak speed/pitch bottom sheet layout Jan 6, 2024
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bnyro Bnyro merged commit 07068a3 into libre-tube:master Jan 6, 2024
3 of 4 checks passed
@RafaelsRamos RafaelsRamos deleted the imp/speed_sheet_layout_tweak branch January 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants