Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear views on VideoAdapter's onBindViewHolder #5497

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

RafaelsRamos
Copy link
Contributor

Issue

  • When scrolling horizontally on the feed, because we are using a recycler view and not resetting the image before a thumbnail is successfully loaded, the image from the view that was previously recycled shows up - The magnitude of this issue depends on the quality of the user's network - fast internet speeds minimize the problem - issue replication below:
before.mp4

What does this PR do?

  • Resets the view before loading a new image to it;

Showcase

after.mp4

@Bnyro Bnyro changed the title Clear views on VideoAdapter's onBindViewHolder fix: clear views on VideoAdapter's onBindViewHolder Jan 16, 2024
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you!

@Bnyro Bnyro merged commit 6dc81c2 into libre-tube:master Jan 16, 2024
3 of 4 checks passed
@RafaelsRamos RafaelsRamos deleted the rafa/reset_view branch January 22, 2024 13:49
@VitoItalianGamer
Copy link

How do I apply this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants