feat(ui): option for automatic update checks #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Feb 27, 2024
app/src/main/java/com/github/libretube/ui/dialogs/UpdateAvailableDialog.kt
Show resolved
Hide resolved
Bnyro
reviewed
Feb 27, 2024
Comment on lines
15
to
19
| fun onCreateDialog( | ||
| changelog: String, | ||
| releaseUrl: String, | ||
| context: Context, | ||
| ): Dialog { |
There was a problem hiding this comment.
Please refactor this so that the arguments are passed as intent extras, basically as it's been before.
This implementation might crash/dismiss the dialog once the theme is changed on certain devices.
There was a problem hiding this comment.
i have used the intent bundle for passing data and have tested well on android 9 and 13 , the lint is asking for SNAKE-CASE in intent data for these two things(changelog and url), should i do it or ignore it because all others are in camelCase
|
You don't need to fix ktlint next time, I usually ignore it as well and just format the whole code from time to time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the blunders of previous pr are deeply regretted @Bnyro . those should not be existing in first place.