Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Jenkinsfile #7

Merged
merged 6 commits into from
Feb 21, 2019
Merged

Create Jenkinsfile #7

merged 6 commits into from
Feb 21, 2019

Conversation

Nancy-Chauhan
Copy link
Member

Added simple Jenkinsfiles to agent images

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not work in such way. For common definitions there should be a singleJenkinsfile in the repository root, which runs CI for the entire repository

Jenkinsfile Outdated
stage("Test") {
sh 'echo this is stage Test'
sh 'export GOSS_FILES_STRATEGY=cp && /usr/local/bin/dgoss run --name jenkins-docker-dgoss-test
--rm -ti docker_image'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this line break?

@oleg-nenashev
Copy link
Member

@mschuchard
Copy link

mschuchard commented Feb 15, 2019

I am not sure if the .dgoss method works, because I am not sure if dgoss is possible inside Jenkins because of the odd choice that was made about how access to the container should work in dgoss. I meant to revisit it at some point, but that was months ago, so I really should have by now.

My specific note on it was:

dgoss does not actually work like you would think and also has pathing issues; workaround with volume mounting

return stages
}

node('master') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to enable a retention strategy here.
E.g. https://github.com/jenkinsci/jenkins/blob/master/Jenkinsfile#L16

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether it works inside node(), but I will give it a try

@oleg-nenashev oleg-nenashev merged commit 97af981 into librecores:master Feb 21, 2019
@oleg-nenashev
Copy link
Member

@mschuchard thanks for the response! I think we will have a follow-up with @Nancy-Chauhan about the dgoss adoption on the instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants