Add support of Building Tools in a Docker image #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
commented
Sep 7, 2017
| @@ -0,0 +1,12 @@ | |||
| FROM librecores/librecores-ci | |||
There was a problem hiding this comment.
Should be replaced by LCCI Tools Base later. Just wanted to have an image with ready python bits
| # github-api-token: <TOKEN> | ||
| volumes: | ||
| #TODO: Make it confurable via API | ||
| tools: lcci-tools |
There was a problem hiding this comment.
Ideally I should add a parameter to the tool for that
There was a problem hiding this comment.
It should also be an absolute path, right?
There was a problem hiding this comment.
No need. Such definition will create a new named docker volume or write to an existing one if it exists.
|
I used it to spin the demo in librecores/librecores-ci-jenkins-server#31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a Docker image, which can be used to quickly deploy tools to a Docker volume without deploying a local environment.
I used it to spin the Endian Swapper demo in #31