Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libredirect should not be the home page or default search engine #101

Closed
mostfunkyduck opened this issue Mar 10, 2022 · 5 comments
Closed

Comments

@mostfunkyduck
Copy link

It's a bad assumption that every user wants to proxy their traffic through the onion site of a browser extension and it's a bad assumption that every user wants that onion site as their homepage. This is totally valid as an option, but it's pretty invasive for an extension to effectively hijack traffic with no warning, especially when that behavior isn't documented. I assume this was done with good intentions, but it's a major red flag.

@ManeraKai
Copy link
Member

Don't worry it's not an onion site, even Facebook can't make http://facebook.onion but instead has http://facebookwkhpilnemxj7asaniu7vnjjbiltxjqhye3mhbshg7kx5tfyd.onion
http://facebookcorewwwi.onion
It's just a fake url that I use to detect the Default Search Engine requests as I can't do that without it. I had two videos in the matrix room explaining what the hell is going on xD:

  1. https://youtu.be/jkna60-nscI
  2. https://youtu.be/ienPi1JkT_E

The browser warns you that the LibRedirect wants to be a Default Search Engine, though if this was a little bit getting into business, I'll try to inform the user of that in a different way.

@ManeraKai
Copy link
Member

So... I've now deleted that notification and added an info message in the Search tab in the settings that states about having it as a default will be the best option if you wanna use the Search feature:
image

@idotj
Copy link

idotj commented Mar 10, 2022

I'm not sure if it is related with the search, but because I saw in the title of this issue "Home page" I would like to add my experience since I installed it.
In my case, every day that I click on my Home icon (at the main browser toolbar) Libredirect wants to change my default search page (that it is already a private search engine)
I didn't find any setting/option to stop doing this when I want to go to my homepage... (and I'm 100% sure that I unable the search option in the plugin)
*Please if you think that this issue is not related, I can copy my comment in a new one and remove this one.
Thanks for your great work!

@ManeraKai
Copy link
Member

I fixed the homepage issue, you can reset it back to the default through here:
image
This (homepage) won't be in the extension anymore. I didn't know that it will behave like that.

@ManeraKai
Copy link
Member

Released a new version with the fixes: https://github.com/libredirect/libredirect/releases/tag/v1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants