Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piped #14

Closed
ghost opened this issue Jan 30, 2022 · 66 comments
Closed

Piped #14

ghost opened this issue Jan 30, 2022 · 66 comments

Comments

@ghost
Copy link

ghost commented Jan 30, 2022

Piped is Privacy-oriented YouTube Frontend which is like Invidious but uses Javascript. I think you can add it as a Separate option instead of mixing in the Invidious Instance Pool.

Open Issue in Main repo : SimonBrazell/privacy-redirect#181

@den7007
Copy link

den7007 commented Jan 30, 2022

Would be great to integrate this so there is no need to install another add-on just for Piped (For the meantime, am using theirs: https://addons.mozilla.org/en-US/firefox/addon/piped-redirects/)

@ghost
Copy link
Author

ghost commented Jan 30, 2022

Yeah, I am also. The Thing is we can make them to can implement Invidious Redirect like there and just redirect to the Invidious Instance we want by just adding an Exception.

@ghost
Copy link
Author

ghost commented Jan 30, 2022

Instances list to be added : https://github.com/TeamPiped/Piped/wiki/Instances

@ghost
Copy link
Author

ghost commented Jan 30, 2022

Just remove the api before implementing because it was to used to use between the Instances in the Own Pool of Instances

@ManeraKai
Copy link
Member

What api do you mean?

@ManeraKai
Copy link
Member

The instances list is the weirdest list I've seen so far. I've eventually got all the URLs correct except for moomoo.me.

@ManeraKai
Copy link
Member

Added it: b4fcdf2

@ghost
Copy link
Author

ghost commented Feb 4, 2022

I mean in the instances list remove api from URL so it might not return a 404 error or a raw JSON data.

@ghost
Copy link
Author

ghost commented Feb 4, 2022

Is it separate from Invidious ?

@ManeraKai
Copy link
Member

Is it separate from Invidious ?

Ofc, you can choose between it and invidious in the settings pages

@ghost
Copy link
Author

ghost commented Feb 4, 2022

Will this be in a New Release or by hitting Update Instances ?

@ghost
Copy link
Author

ghost commented Feb 4, 2022

I think you can also consider this - SimonBrazell/privacy-redirect#181 (comment)

Even redirecting invidious to Piped links if we want invidious links not to redirect we can use an Exception rule which will be useful. This is actually working of the Official Piped extension but there is not exception like in Lib or Privacy redirect.

@ManeraKai
Copy link
Member

Will this be in a New Release or by hitting Update Instances ?

Update instances only updates a json file containing a list of working insances. This new code should be in a new release.

@ManeraKai
Copy link
Member

I think you can also consider this - SimonBrazell/privacy-redirect#181 (comment)
Even redirecting invidious to Piped links if we want invidious links not to redirect we can use an Exception rule which will be useful. This is actually working of the Official Piped extension but there is not exception like in Lib or Privacy redirect.

Why do you want to redirect invidious links?

@ghost
Copy link
Author

ghost commented Feb 4, 2022

I think you can also consider this - SimonBrazell#181 (comment)
Even redirecting invidious to Piped links if we want invidious links not to redirect we can use an Exception rule which will be useful. This is actually working of the Official Piped extension but there is not exception like in Lib or Privacy redirect.

Why do you want to redirect invidious links?

Because Piped is better than Invidious in terms of overall Use, Performance and Stability and unlike Slow development of Invidious it is developing at a faster rate and the community like it.

@ghost
Copy link
Author

ghost commented Feb 4, 2022

That is also why I told you that if we need Invidious we can make a exception. If you are worried that other users will not know better make a notice about it when using the feature.

@ManeraKai
Copy link
Member

I mean the only links that the user will click are youtube links, I didn't see any invidious link other than in matrix rooms

@ManeraKai
Copy link
Member

I already made Piped the default option, users can however choose the frontend they want:
image

@ManeraKai
Copy link
Member

Same thing goes for Translate, Search, Reddit. All have multiple frontends that you can choose which one in the settings. However, the best option is the default option.

@ghost
Copy link
Author

ghost commented Feb 4, 2022

I think you should use the Official Piped Redirects extension, enable it and then click on Invidious and YouTube Links with Libredirect disabled.

@ghost
Copy link
Author

ghost commented Feb 4, 2022

You will then understand by what I mean

@ManeraKai
Copy link
Member

ManeraKai commented Feb 4, 2022

I've now done that, yeah redirecting Invidious links to Piped, but why? No one uses invidious links to share media.

@ManeraKai
Copy link
Member

Maybe I'm missing something?

@ghost
Copy link
Author

ghost commented Feb 4, 2022

Maybe I'm missing something?

Because privacy oriented guys like Techlore in their surveillance Report and majority of matrix users use Invidious links of Instead of YouTube which is very much old schooled and broken often at sometimes so you don't get to like to view it and also in Piped we have an account system like Piped and settings that apply cross site. But in Invidious we need to have the settings already and need to save it as a cookie and also we may clear and many consequences to face with Invidious such as Google Captchas & limits number of users or Video Player Broke, etc.

That is why I also propose a solution add a banner in the section and use of exception solves this.

@ManeraKai
Copy link
Member

ManeraKai commented Feb 4, 2022

I see, I'll make it when invidious is selected, it will forward youtube and piped urls to it. Same thing for piped, it will redirect youtube and invidious links to it. Same for FreeTube too...

That is why I also propose a solution add a banner in the section and use of exception solves this.

If a person chose to view videos in a specific Frontend, then I don't think they want to have exceptions. If someone requested that feature, I'll add it.

What do you think @Loki-L1130 ?

@ghost
Copy link
Author

ghost commented Feb 5, 2022

@ManeraKai I think this is pretty much a great Idea to implement. Both Invidious and Piped users gets benefit of this.

With the exceptions, You don't need to do anything as in the exceptions menu of Libredirect, If we add a URL it is automatically excluded from redirection. That's it. You just need to force the URLs to redirect to specific Frontends.

This is personal Question, How to actually use the Freetube Redirect because I haven't used it from the start ?

@ghost
Copy link
Author

ghost commented Feb 5, 2022

Does the settings you have for Invidious do apply to Piped too ?

@alefvanoon
Copy link
Member

Does the settings you have for Invidious do apply to Piped too ?

No, I don't think Piped have this options.
CC: @FireMasterK

@ManeraKai
Copy link
Member

This is personal Question, How to actually use the Freetube Redirect because I haven't used it from the start ?

Just install FreeTube, and select it as a frontend, this is how it redirects in code: https://github.com/libredirect/libredirect/blob/master/src/assets/javascripts/helpers/youtube/youtube.js#L239

original: https://www.youtube.com/watch?v=J4osVFVeQrI
new: freetube://https://www.youtube.com/watch?v=J4osVFVeQrI

@ManeraKai
Copy link
Member

Does the settings you have for Invidious do apply to Piped too ?

Not yet, but that is a nice idea btw.

@ghost
Copy link
Author

ghost commented Feb 5, 2022

Isn't the extension considered as the full implementation?

Yeah, It is but it has issues with replacing embeds of Shorts Videos alone. Which I think could be fixed as Invidious does this perfectly. May consider this as you could be able to fix this.

@ManeraKai
Copy link
Member

in invidious redirection: just delete of the /shorts path
https://github.com/libredirect/libredirect/blob/master/src/assets/javascripts/helpers/youtube/youtube.js#L268

@ghost
Copy link
Author

ghost commented Feb 5, 2022

So, You mean it is possible on Piped like you did for Invidious or does @FireMasterK do need to change anything on the Frontend side ?

@ManeraKai
Copy link
Member

Youtube shorts are just like regular videos.

do need to change anything on the Frontend side ?

No need, hopefully

@ghost
Copy link
Author

ghost commented Feb 5, 2022

So, You made the shorts video to be like a normal Video - Right ?

@ManeraKai
Copy link
Member

yep

@ghost
Copy link
Author

ghost commented Feb 5, 2022

Great, Then, I think everything is solved and Piped is Ready for Deployment.

@ManeraKai
Copy link
Member

Just test it first if you can.

@ghost
Copy link
Author

ghost commented Feb 5, 2022

Sure, But How ?

@ghost
Copy link
Author

ghost commented Feb 5, 2022

Does the settings you have for Invidious do apply to Piped too ?

Maybe this is pending.

@ManeraKai
Copy link
Member

If you find a YouTube short link, try to remove the /shorts thingy. This needs a phone btw.

@ghost
Copy link
Author

ghost commented Feb 5, 2022

Sure, I do have a Shorts Video Link. Check it out here : https://www.youtube.com/shorts/ilC3t2VvOw0

@ManeraKai
Copy link
Member

ManeraKai commented Feb 5, 2022

@ghost
Copy link
Author

ghost commented Feb 5, 2022

Yeah, It is but what if instead of /shorts it shows /watch?v= in URL

@ManeraKai
Copy link
Member

Piped iteself redirected that. I can added though myself to LibRedirect, no big deal

@ghost
Copy link
Author

ghost commented Feb 5, 2022

But I mean the UI. Go to this Issue, TeamPiped/Piped-Redirects#10

and see this video :
image

@ManeraKai
Copy link
Member

I'll see what I can do.. weird stuff tbh

@ManeraKai
Copy link
Member

ManeraKai commented Feb 5, 2022

and see this video :

@Loki-L1130 can you give the link of the site

@ghost
Copy link
Author

ghost commented Feb 5, 2022

It is Inoreader, My RSS reader where I have my YouTube Subscriptions.

@ghost
Copy link
Author

ghost commented Feb 6, 2022

Kai, You used a confused Emoji. What's up with the thing. Is there ways I can help.

@ManeraKai
Copy link
Member

I need a site that has an iframe of a youtube shorts video

@ghost
Copy link
Author

ghost commented Feb 6, 2022

I think there is none available like that. Your best bet would be using Inoreader(Closed Source) with an Alias or Feedbin (Premium, OpenSource with trial no credit card needed) which also suffers from this.

@ghost
Copy link
Author

ghost commented Feb 7, 2022

@ManeraKai, I tried the new Version of Libredirect. But the Shorts video is not in the 16:9 ratio like in the Movies.

@ManeraKai
Copy link
Member

@ManeraKai, I tried the new Version of Libredirect. But the Shorts video is not in the 16:9 ratio like in the Movies.

I think that should be a bug in the iframe. I can't do anything about it.
I've helped and even made short YouTube links as normal ones, that didn't help apparently.

@ghost
Copy link
Author

ghost commented Feb 7, 2022

Okay, I think that is in the hands of @FireMasterK . We shall see about it later.

@ghost
Copy link
Author

ghost commented Feb 7, 2022

Thanks for adding Piped.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants