-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Piped Material #51
Comments
Piped is working on a redesign at New Piped UIl which is very similar to piped material, I’m really indifferent towards this issue, but just wanted to throw that in here |
Indeed, I'm aware of that. However PM has some irreconcilable and systematic changes that do make it a descendant but not a drop-in replacement for Piped. UI-v2 is just a redesign, which unfortunately also seems to be somewhat dead in the water. It's also not very Material Design.
Perhaps I should consider changing the name to something totally different.
Regards,
…On 20/02/22 04:28, IronMaltese wrote:
Piped is working on a redesign at [](https://ui-v2.piped.pages.dev/) which is very similar to piped material, I’m really indifferent towards this issue, but just wanted to throw that in here
|
Interesting, why didn't you create some pull requests though? Piped is still a new project for it to be forked and is still worked on everyday. |
Too many things. There is deep philosophical disconnect between Piped and PM, since PM takes a radically different approach to the design, Vue 2 vs Vue 3, structural issues. I don't think Kavin would want to maintain it. I wouldn't want to force it either.
Regards,
…On 20/02/22 05:28, ManeraKai wrote:
Interesting, why didn't you create some pull requests though? Piped is still a new project for it to be forked and is still worked on everyday.
|
Hi, the project looks nice, but somehow I can't see 1080p options, even after adjusting the preferences? For example: While I can in |
@stephenhawk8054 commented on 20 Feb 2022, 10:25 am IST:
|
Can't seem to successfully add custom settings. I'll try to work on that more. But it's working!! |
Custom settings may require a patch, is it possible to release without custom settings? I'll let you know when it's fixed though.
Regards,
…On March 4, 2022 12:46:14 AM GMT+05:30, ManeraKai ***@***.***> wrote:
Can't seem to successfully add custom settings. I'll try to work on that more. But it's working!!
--
Reply to this email directly or view it on GitHub:
#51 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Yeah np, I'll update you about new fixes in this issue. |
Well, It seems broken in terms of Redirects in the Latest Commits |
What does redirect entail here exactly? Just curious.
Regards,
…On 3/4/22 10:18, Loki wrote:
Well, It seems broken in terms of Redirects in the Latest Commits
|
Well, When choosing Piped Material to redirect youtube. It doesn't redirect and still goes to youtube.com |
@Loki-L1130 I didn't release a new version it yet. |
Released a new version. Everything should work now. Well, other than the URL parameters. |
I think I received the update, but redirects definitely don't work and I don't see a list of Piped Material instances.
Regards,
…On 05/03/22 00:55, ManeraKai wrote:
Released a new version. Everything should work now.
|
1.4.8? |
I removed and reinstalled the addon and it seems to work now. But I think I still received the update since I saw the Piped Material option which was only recently introduced with 1.4.8, right?
My guess is if I'm right something broke during the migration.
Regards,
…On 05/03/22 00:59, ManeraKai wrote:
1.4.8?
|
I added the option at 1.4.7 I think and enabled it's function on 1.4.8. Can you show me a picture of what's happening. |
Since I reinstalled it, it seems to be working fine. Nothing interesting except youtu.be -> PM redirects.
Regards,
…On 05/03/22 01:15, ManeraKai wrote:
I added the option at 1.4.7 I think and enabled it's function on 1.4.8. Can you show me a picture of what's happening.
What does the console in this url says to you: `about:devtools-toolbox?id=7esoorv3%40alefvanoon.anonaddy.me&type=extension`
|
? |
PM = Piped Material.
Regards,
…On 05/03/22 01:21, ManeraKai wrote:
> youtu.be -> PM redirects.
?
|
I know but what's wrong with youtu.be? |
Err I actually meant it contains nothing but youtu.be -> PM redirects. Eitherway it works fine.
Regards,
…On 05/03/22 01:27, ManeraKai wrote:
I know but what's wrong with youtu.be?
|
I'll close the issue as it's has been added. I'll work on the parameters problem more in the future. |
DISCLAIMER: I'm the sole developer of Piped Material, but I think users will appreciate this feature and at least one user has asked for this.
Piped Material is a fork off Piped, with a few advantages. It'll be nice to see it as an option beside Piped. It uses the same API as Piped and therefore instances, but not the frontends.
There's a grid of frontend instances in the repo below, I'd recommend only adding the production instance for now.
URL: https://github.com/mmjee/Piped-Material
The text was updated successfully, but these errors were encountered: