Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Piped Material #51

Closed
mmjee opened this issue Feb 19, 2022 · 24 comments
Closed

Add support for Piped Material #51

mmjee opened this issue Feb 19, 2022 · 24 comments
Labels
enhancement New feature or request

Comments

@mmjee
Copy link

mmjee commented Feb 19, 2022

DISCLAIMER: I'm the sole developer of Piped Material, but I think users will appreciate this feature and at least one user has asked for this.

Piped Material is a fork off Piped, with a few advantages. It'll be nice to see it as an option beside Piped. It uses the same API as Piped and therefore instances, but not the frontends.

There's a grid of frontend instances in the repo below, I'd recommend only adding the production instance for now.

URL: https://github.com/mmjee/Piped-Material

@davidcollini
Copy link

davidcollini commented Feb 19, 2022

Piped is working on a redesign at New Piped UIl which is very similar to piped material, I’m really indifferent towards this issue, but just wanted to throw that in here

@mmjee
Copy link
Author

mmjee commented Feb 19, 2022 via email

@ManeraKai
Copy link
Member

Interesting, why didn't you create some pull requests though? Piped is still a new project for it to be forked and is still worked on everyday.

@mmjee
Copy link
Author

mmjee commented Feb 20, 2022 via email

@stephenhawk8054
Copy link
Contributor

Hi, the project looks nice, but somehow I can't see 1080p options, even after adjusting the preferences?

For example:
https://piped-material.ftp.sh/watch?v=mk48xRzuNvA

image

While I can in piped.kavin.rocks

image

@mmjee
Copy link
Author

mmjee commented Feb 20, 2022

@stephenhawk8054 commented on 20 Feb 2022, 10:25 am IST:

Hi, the project looks nice, but somehow I can't see 1080p options, even after adjusting the preferences?

For example:
https://piped-material.ftp.sh/watch?v=mk48xRzuNvA

image

While I can in piped.kavin.rocks

image

image
I don't see 1080p either, under the hood both Piped and PM have almost the same code handling playing videos, so if it reproduces, should be an easy fix.

@ManeraKai ManeraKai added the enhancement New feature or request label Mar 1, 2022
ManeraKai added a commit that referenced this issue Mar 3, 2022
@ManeraKai
Copy link
Member

Can't seem to successfully add custom settings. I'll try to work on that more. But it's working!!

@mmjee
Copy link
Author

mmjee commented Mar 3, 2022 via email

@ManeraKai
Copy link
Member

ManeraKai commented Mar 4, 2022

Yeah np, I'll update you about new fixes in this issue.

@ghost
Copy link

ghost commented Mar 4, 2022

Well, It seems broken in terms of Redirects in the Latest Commits

@mmjee
Copy link
Author

mmjee commented Mar 4, 2022 via email

@ghost
Copy link

ghost commented Mar 4, 2022

Well, When choosing Piped Material to redirect youtube. It doesn't redirect and still goes to youtube.com

@ManeraKai
Copy link
Member

@Loki-L1130 I didn't release a new version it yet.

@ManeraKai
Copy link
Member

ManeraKai commented Mar 4, 2022

Released a new version. Everything should work now. Well, other than the URL parameters.

@mmjee
Copy link
Author

mmjee commented Mar 4, 2022 via email

@ManeraKai
Copy link
Member

1.4.8?

@mmjee
Copy link
Author

mmjee commented Mar 4, 2022 via email

@ManeraKai
Copy link
Member

I added the option at 1.4.7 I think and enabled it's function on 1.4.8. Can you show me a picture of what's happening.
What does the console in this url says to you: about:devtools-toolbox?id=7esoorv3%40alefvanoon.anonaddy.me&type=extension

@mmjee
Copy link
Author

mmjee commented Mar 4, 2022 via email

@ManeraKai
Copy link
Member

youtu.be -> PM redirects.

?

@mmjee
Copy link
Author

mmjee commented Mar 4, 2022 via email

@ManeraKai
Copy link
Member

I know but what's wrong with youtu.be?

@mmjee
Copy link
Author

mmjee commented Mar 4, 2022 via email

@ManeraKai
Copy link
Member

I'll close the issue as it's has been added. I'll work on the parameters problem more in the future.

ManeraKai added a commit that referenced this issue May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants