Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Embed Frontend" feature for youtube #624

Closed
Sentenza-Git opened this issue Feb 6, 2023 · 35 comments
Closed

"Embed Frontend" feature for youtube #624

Sentenza-Git opened this issue Feb 6, 2023 · 35 comments
Labels
enhancement New feature or request

Comments

@Sentenza-Git
Copy link

Since version 2.5.0 it is no longer possible to activate the FreeTube redirection and at the same time the invadious redirection with the option "Embed Frontend".

 6-02-2023_22-51-41

OS: Linux Mint 20.3
Firefox 109.0.1
FreeTube 0.18.0
libredirect 2.5.x

@ManeraKai ManeraKai added the enhancement New feature or request label Feb 7, 2023
@ManeraKai
Copy link
Member

Will be closed in favor of Frontends Manager, having an app as a replacement for a website is not a good idea, iframes will be one of the problems that will pop up. Frontends Manager will solve this hopefully.

@XxTriviumxX
Copy link

XxTriviumxX commented Jun 9, 2023

In response for duplicate #734 issue:

Will be closed in favor of Frontends Manager

Youtube redirect is not available on Frontend Manager. Why would you want to close this feature request?

having an app as a replacement for a website is not a good idea

Why are you promoting the Frontend Manager app? It's an app.

I am most likely completely off with my reply to be honest. I'm just confused.

@ManeraKai
Copy link
Member

Youtube redirect is not available on Frontend Manager. Why would you want to close this feature request?

I'm working on adding Invidious and Piped to it.

@XxTriviumxX
Copy link

XxTriviumxX commented Jun 9, 2023

Will you consider adding the feature to the libredirect extension too?

As for the Frontends Manager App it is only available on debian based OS. Can you push an AUR for the Arch linux users? Or at least a flatpak?

I have to use RSS feeds to get notified for new versions for the appimage ... and the appimage requires me to install docker too, which i don't really want in my system.. but i guess i can install it for this tool.

edit: that app doesnt work. libreddit is not redirected.

@ManeraKai
Copy link
Member

ManeraKai commented Jun 9, 2023

Will you consider adding the feature to the libredirect extension too?

Which feature?

As for the Frontends Manager App it is only available on debian based OS. Can you push an AUR for the Arch linux users? Or at least a flatpak?

Flatpak will be supported in future once I figure that out.

edit: that app doesnt work. libreddit is not redirected.

Go to setting s in the extension and change "instance" to "localhost"

@XxTriviumxX
Copy link

Im talking about the feature like in the picture above. You removed the feature of putting freetube frontend and invidious enbed frontend. Is there any hope you can put it back on with the extension?

@ManeraKai ManeraKai reopened this Jun 9, 2023
@XxTriviumxX
Copy link

XxTriviumxX commented Jun 9, 2023

Go to setting s in the extension and change "instance" to "localhost"

works great! But, please keep working on the browser extension... its awesome!

I have a question though.. how do you keep those local frontends up to date? Do they get updated at the same time the app itself gets updated?

edit: The appimage made me download "caddy" too. How does it keep it updated?

@ManeraKai
Copy link
Member

works great! But, please keep working on the browser extension... its awesome!

bruh ofc I will be working on the extension xD. The app is just for hosting the frontends not for redirecting.

I have a question though.. how do you keep those local frontends up to date? Do they get updated at the same time the app itself gets updated?

Well I'm still working on this thing, but it's completely separated from the AppImage, they get downloaded from here: https://github.com/libredirect/frontends_binaries

edit: The appimage made me download "caddy" too. How does it keep it updated?

Caddy is like Nginx, a server manager. It allows me to have "libreddit.localhost:8080" "rimgo.localhost:8080" urls on the same port.

@XxTriviumxX
Copy link

XxTriviumxX commented Jun 10, 2023

bruh ofc I will be working on the extension xD.

That's great!! i thought you were dumping this feature request and put it in the app and the app only because 2 weeks ago you commented:

Will be closed in favor of Frontends Manager

Another thing, the appimage downloaded caddy... where is the downloaded caddy and how do i get rid of it? By simply deleting the appimage?

edit: arch linux pc.

@ManeraKai
Copy link
Member

ManeraKai commented Jun 10, 2023

That's great!! i thought you were dumping this feature request and put it in the app and the app only because 2 weeks ago you commented

I really want to but your making me feel guilty xD

@Victor239
Copy link

Victor239 commented Jun 10, 2023

I agree with the OP here - I really enjoy FreeTube as it let's me locally subscribe to channels, create categories and star favourites. It's a superior alternative to the web-based frontends with many features, so I want to opportunistically use it whenever possible.

The UI for LibRedirect's YouTube settings trying to simultaneously use FreeTube but also redirecting embeds to another frontend has been weird for a while, but I thought it was instead going to be resolved like this:

  • New dropdown setting called Desktop App with the choices of "Disabled" (default), "FreeTube", and potentially other desktop apps like KDE's PlasmaTube and Tubefeeder.
  • If the setting is changed from "Disabled", then Redirect Type setting is forced to "Only Embedded", and uses whatever is set in the Frontend setting.

Would love to see a similar approach for all frontends eventually - it doesn't seem too difficult to allow users to use desktop apps whenever possible, and it could expand the number of centralised services that are supported.

@XxTriviumxX
Copy link

I really want to but your making me feel guilty xD

But it was a super cool feature!!!! LOL Jokes aside... Why did it get removed? Was it problematic?

Another thing, the appimage downloaded caddy... where is the downloaded caddy and how do i get rid of it? By simply deleting the appimage?

edit: arch linux pc.

plocate was buggy yesterday. It got fixed this morning with its last patch.

I found caddy there:

$ locate caddy
/home/user/.config/caddy
/home/user/.config/caddy/autosave.json
/home/user/.local/share/org.libredirect.frontends-manager/caddy
/home/user/.local/share/org.libredirect.frontends-manager/caddy/caddy_linux_amd64

In order to remove caddy, do i simply remove those dirs and files?

@ManeraKai
Copy link
Member

@XxTriviumxX It's just here ~/.local/share/org.libredirect.frontends-manager/caddy/caddy_linux_amd64

@ManeraKai
Copy link
Member

@Victor239 The thing is Desktop Apps are meant to be used without the browser, but we're doing the opposite.
The thing that I really wanna see is FreeTube opened in a browser tab. It's already built using Electron so this should be possible, and it will be a lot better to use imo (bc of embeds and all the other things a browser has). In other words I want to encourage using frontends that are "headless but run in the browser rather than in a separate window".

@Victor239
Copy link

The thing is Desktop Apps are meant to be used without the browser, but we're doing the opposite.

I use FreeTube without an open browser daily (saves memory and less distractions), but when I do come across a video in my browser I'm also able to easily view it in my FreeTube, where I can save it and it's added to my local history. It's seamless integration, and best of both worlds.

Web-based frontends on the other hand require an open browser if you use Firefox like I do (as it has poor PWA support).

The thing that I really wanna see is FreeTube opened in a browser tab. It's already built using Electron so this should be possible, and it will be a lot better to use imo (bc of embeds and all the other things a browser has).

Some frontends are limited by Web APIs however, which makes desktop apps more suitable in some cases. For example there's the FreeTube Cordova fork, which turns it into a web app and then an Android app. It isn't able to use the Local API for streaming from YouTube, and instead has to rely on the Invidious API to stream from an instance.

If that can be resolved however I do agree it'd be interesting to see FreeTube in a browser, it'd be a better frontend than Invidious. But I can still imagine several limitations, like it not being able to opened directly from my desktop and instead requiring the Frontend Manager to be initialised first.

In other words I want to encourage using frontends that are "headless but run in the browser rather than in a separate window".

I understand wanting to primarily support web-based frontends, but this would also mean cutting off useful desktop frontends from being used until work is done to rearchitect them to also work as web apps and then the limitations that come with it.

In the meanwhile I want to use all the features of FreeTube, and not settle for Invidious. I want to use LBRY, not Odysee. I want to use Giara, not Teddit.

Sometimes I even get a bunch of links to YouTube music videos and wish I could have them open in my YouTube -> MP3 downloader desktop app.

I hope you'll consider allowing users to still use a desktop app if they wish.

@XxTriviumxX
Copy link

XxTriviumxX commented Jun 11, 2023

to encourage using frontends that are "headless but run in the browser rather than in a separate window".

The option for online privacy focused desktop apps is not a huge deal to make and maintain. The real thing to encourage here is online privacy itself and the convenience to get it.

@XxTriviumxX
Copy link

can't wait to use the feature and ditch the privacy redirect extension. Thank you for reconsidering the feature.

@ManeraKai
Copy link
Member

@Victor239 Your points are really valid, but just one question about the implementation, have you used LibRedirect prior to 2.3.4. Isn't the having an "Embed frontend" selection a better UI design?

@Victor239
Copy link

Could you post a screenshot of it what that was like? In it's previous version I remember that if you select "FreeTube" as the frontend then you weren't able to specify which other frontend would handle the embeds, which is why I suggested the alternative UI options above.

@XxTriviumxX
Copy link

XxTriviumxX commented Jun 19, 2023

Could you post a screenshot of it what that was like?

154353435-7f454c98-d74e-4726-b9e5-7e92aee0a05a

it was awesome.

@ManeraKai
Copy link
Member

The last design v2.3.4: #624 (comment)

@Victor239
Copy link

Ah I see, yeah that UI looks fine actually. I must be just remembering an even older version.

ManeraKai added a commit that referenced this issue Jun 19, 2023
@ManeraKai
Copy link
Member

Alright, I just hope nothing will break bc I changed so many sensitive things. Will need some testing before release:
screenshot

@XxTriviumxX
Copy link

XxTriviumxX commented Jun 19, 2023

I changed so many sensitive things

i didn't know it was THAT complicated.. but thanks a bunch! I will contribute if i ever find bugs by creating relevent issues.

@ManeraKai
Copy link
Member

@XxTriviumxX See our matrix room for v2.7.0:
image

@pm4rcin
Copy link

pm4rcin commented Jun 30, 2023

@ManeraKai regarding embedded frontend what about adding option to use any frontend (invidious/piped)? Since it's embed I don't think many people care which frontend it actually is since they just want to have the video loaded.

@XxTriviumxX
Copy link

XxTriviumxX commented Jun 30, 2023

I don't think many people care which frontend it actually is since they just want to have the video loaded.

it matters. people should have the power to choose between at least invidious and piped.. as a matter of fact, invidious has been broken for days now. piped is the only viable workaround

@pm4rcin
Copy link

pm4rcin commented Jun 30, 2023

I don't think many people care which frontend it actually is since they just want to have the video loaded.

it matters. people should have the power to choose between at least invidious and piped.. as a matter of fact, invidious has been broken for days now. piped is the only viable workaround

I don't mean removing but adding 3rd choice as another option. ;)

Regarding Invidious being broken I don't know what you're talking about. I've tried random instance just now and it works. Maybe your instance is broken?

@ManeraKai
Copy link
Member

ManeraKai commented Jun 30, 2023

I don't mean removing but adding 3rd choice as another option. ;)

No this will over complicate things and won't scale well. I need to know what frontend the user is using to determine which frontend function to execute for converting the url.

@XxTriviumxX
Copy link

they mostly use invidious and piped for enbedded.

@ManeraKai
Copy link
Member

ManeraKai commented Jul 27, 2023

It is already there, you just need to select both in Redirect Type.

@ManeraKai
Copy link
Member

image

@ManeraKai
Copy link
Member

bc you are using Piped, oh I see now. The feature is only for Freetube bc it doesn't support embeds.

@XxTriviumxX
Copy link

nevermind. i used piped.. because i had to use another extension to handle freetube. my bad

@XxTriviumxX
Copy link

XxTriviumxX commented Jul 27, 2023

Thanks for the new function and thank you for your patience. ADHD kicked hard today

edit: privacy redirect just kicked the bucket. i only have 2 extensions now thanks to you. Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

5 participants