Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Excluded from redirecting' Doesn't work. #665

Closed
amogusussy opened this issue Mar 17, 2023 · 8 comments
Closed

'Excluded from redirecting' Doesn't work. #665

amogusussy opened this issue Mar 17, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@amogusussy
Copy link

In the settings, I've set youtube.com (only the root URL) to not redirect, (screenshot) but when I open youtube.com, it still redirects to an invidious instance.

I only want it to redirect for youtube.com/watch URLs, and nothing else on the youtube.com domain. Is there a way to do this, or fix this bug?

@ManeraKai ManeraKai added the bug Something isn't working label Mar 17, 2023
@ManeraKai
Copy link
Member

ManeraKai commented May 12, 2023

The thing is Exclude from redirecting is taking everything "literally". What I understood was happening was that normally (without LibRedirect) when you type youtube.com, you go to http://youtube.com and then you get redirected to the https version (https://youtube.com), but LibRedirect intercepts the first one (http://youtube.com) and recognize it as not in the excluded list, so it redirects it xD.
I (as an advanced user) prefer the Regex way:
image
https?:\/\/youtube\.com\/?$
The problem is I can't know if the user is literally meaning to just not redirect the https version, or he is meaning both http and https, or he wants the last slash in the url, or not.
I will though make a change to ignore http and https, and also the last slash, and let's see if one disagrees in the future.

@ManeraKai
Copy link
Member

Alright, till the next release comes out, you can use the Regex: https?:\/\/youtube\.com\/?$.

CatCoder32 pushed a commit to CatCoder32/extension_browser that referenced this issue Jun 15, 2023
CatCoder32 pushed a commit to CatCoder32/extension_browser that referenced this issue Jun 15, 2023
@Elaborendum
Copy link
Contributor

As of the latest version, it seemingly still doesn't work for me. The regex method excludes the main website, but embeds inside the page still get redirected.

@ManeraKai
Copy link
Member

ManeraKai commented Sep 6, 2023

@Elaborendum is this still the same in v2.8.0?

@Elaborendum
Copy link
Contributor

Yes, that's still the case. Just excluded and tried it out on https://youtubeembedcode.com, the embedded video still got redirected to one of my chosen invidious instances. If I just disable YouTube redirecting altogether it loads YouTube so it's not another extension.

@ManeraKai
Copy link
Member

Try to add https://youtubeembedcode.com/en/ to your exceptions rather than just https://youtubeembedcode.com/.

@Elaborendum
Copy link
Contributor

Elaborendum commented Sep 10, 2023

That works, but I swear that's different from the way it used to be. Now it has to match exactly the full exact URL for it to be excluded and not just the main domain. For example, I have "meet.jit.si" added to the exclusion list to allow for shared embeds to work properly in video calls and I remember it used to work. Currently I'd have to add the exact URL of each new videocall for it to be excluded from redirection.

Also explains why the regex options didn't work for me anymore either, as they only covered the main domain and possible subdomains, changing them to include the slug in the pattern makes them work again. I also probably need to change most of my exclusions to regex if I want them to work.

@ManeraKai
Copy link
Member

Yes you should change most to regex. I can't predict what the user wants exactly that's why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants