Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon doesn't work in Firefox 68 #759

Closed
Anonymous1157 opened this issue Jul 14, 2023 · 2 comments
Closed

Addon doesn't work in Firefox 68 #759

Anonymous1157 opened this issue Jul 14, 2023 · 2 comments

Comments

@Anonymous1157
Copy link

Hi! I tried using the Firefox addon on a legacy platform where the newest possible version of Firefox is 68, and it doesn't work.

I'm able to install the latest version from the Mozilla addons website, and I get a toolbar icon. When I open libredirect's menu, instead of getting the list of toggles, I only see the Settings option, and clicking on it doesn't do anything. I tried installing older versions of the addon and none of them work as far back as 1.7.0; I don't think old Firefox was ever working and I might be the first person to have ever tried.

In the Browser Console, when I open the libredirect menu I get...

init.js:7:6 SyntaxError: await is a reserved identifier
popup.js:13:15 SyntaxError: await is a reserved identifier

I don't know JS and everything I know is from five minutes of web searching, but what I think is happening is that these are top-level await calls, support for which was only added in Firefox 89 according to this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await#browser_compatibility

Looks like there's two possible solutions:

  • If libredirect really did mean to support Firefox this old, refactor the code to remove top-level await calls or move them into async functions
  • Bump the minimum requirement to Firefox 89
@ManeraKai
Copy link
Member

I think we'll bump the minimum requirement then.

@Tallefer
Copy link

@Anonymous1157

Hi! I tried using the Firefox addon on a legacy platform where the newest possible version of Firefox is 68, and it doesn't work.

I don't remember the exact version of Firefox, but it was comparably old. I commented in the year-old similar issue here #117 (comment)

I'm able to install the latest version from the Mozilla addons website, and I get a toolbar icon. When I open libredirect's menu, instead of getting the list of toggles, I only see the Settings option, and clicking on it doesn't do anything. I tried installing older versions of the addon and none of them work as far back as 1.7.0; I don't think old Firefox was ever working and I might be the first person to have ever tried.

so you may try older versions if you can, or edit either 1.6.3 or 1.7.0 - I made them work for me until I was able to update to later versions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants