Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

causing weird errors with websites #765

Closed
ghost opened this issue Jul 22, 2023 · 13 comments
Closed

causing weird errors with websites #765

ghost opened this issue Jul 22, 2023 · 13 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 22, 2023

the extension seems to be interfering with the loading of images and videos. I know it is libredirect because I've tested my extensions one by one. no images/videos seem to be loading. I'm using version 2.7.0 released today.

@aurtzy
Copy link

aurtzy commented Jul 22, 2023

Hey @cyberhardt, I was just about to report what I believe is the same bug you're encountering - can you try setting the "Unsupported iframes handling" option for Twitter to "bypass"?

@candlew1ck
Copy link

Same issue here, and changing the setting mentioned by @aurtzy fixed it. But why twitter? None of the images from the sites I'm visiting are from twitter. That's weird.

@ghost
Copy link
Author

ghost commented Jul 22, 2023

@aurtzy yep, that seems to be the issue. odd.

@ManeraKai
Copy link
Member

Show me a page example.

@ghost
Copy link
Author

ghost commented Jul 22, 2023

@ManeraKai

image

@ManeraKai
Copy link
Member

This is not happening to me, here are my settings:
image

@ghost
Copy link
Author

ghost commented Jul 22, 2023

same settings here, but media doesn't load unless I set it to bypass

@aurtzy
Copy link

aurtzy commented Jul 22, 2023

I am able to reproduce this issue with a fresh Firefox profile, adding this extension, enabling Twitter and switching only the "Unsupported iframes handling" setting to "block".

Could some external factor be causing this if @ManeraKai can't reproduce it? I'm currently seeing this on the Firefox Flatpak for Linux, version 115.0.2 if that helps reveal anything.

It seems like images specifically are being blocked by LibRedirect. Videos still work fine. This is what the network tab in the console looks like for this page:

screenshot_2023-07-22T0321

Edit: I missed in the original report that videos don't work for you, @cyberhardt? Strange - I can still get videos to play on e.g. https://piped.kavin.rocks, but it's just the images that don't load.

@davidkopp
Copy link

I have the same issue. However, a change of the Twitter settings didn't work for me. Instead, I had to change the YouTube setting "Unsupported iframes handling" to bypass.

ManeraKai added a commit that referenced this issue Jul 22, 2023
@ManeraKai
Copy link
Member

Try this zip out and see: libredirect-2.7.1.zip

@ManeraKai ManeraKai added the bug Something isn't working label Jul 22, 2023
@davidkopp
Copy link

Try this zip out and see: libredirect-2.7.1.zip

Works for me :) Thank you!

@ghost
Copy link
Author

ghost commented Jul 22, 2023

@aurtzy videos do load here, my bad. the thumbnails weren't loading, that was it. btw, I'm on the latest librewolf

@aurtzy
Copy link

aurtzy commented Jul 22, 2023

No worries, I just thought it was something worth mentioning in case there was more to the issue.

The zip seems to work fine for me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants