Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle youtu.be for Freetube redirect #393

Conversation

mittermichal
Copy link

Freetube doens't handle case when videoID is just path (https://youtu.be/XXX) Freetube could handle this properly, but its much easier to fix and release this extension I guess.

Freetube doens't handle case when videoID is just path. Freetube could handle this properly, but its much easier to fix and release this extension I guess.
ManeraKai added a commit that referenced this pull request Aug 9, 2022
@ManeraKai
Copy link
Member

Thanks! and sorry for being late

@ManeraKai ManeraKai closed this Aug 9, 2022
@absidue
Copy link

absidue commented Aug 14, 2022

This isn't actually an issue with FreeTube instead it's caused by libredirect passing https://youtube.com/tviXEaGS1tk (which is an invalid YouTube URL and 404s on the official site as well) to FreeTube instead of https://youtu.be/tviXEaGS1tk. When you do it properly freetube://https://youtu.be/tviXEaGS1tk it works fine.

@mittermichal
Copy link
Author

@absidue thanks

@ManeraKai
Copy link
Member

I'll fix that.

@absidue
Copy link

absidue commented Sep 24, 2022

@ManeraKai looks like the code is still broken.
https://github.com/libredirect/libredirect/blob/master/src/assets/javascripts/youtube/youtube.js#L344-L345

this code should work:

return `freetube://${url}`

@IkelAtomig
Copy link
Member

IkelAtomig commented Sep 26, 2022

@absidue Please see - FreeTubeApp/FreeTube#1598 (comment)

We are using the right URL. If you face issues, It is already logged and being fixed in v2.3. There's a lot of stuff undergoing changes. Stay tuned 😉

@absidue
Copy link

absidue commented Sep 26, 2022

@EdwardLangdon As someone who works on FreeTube, please just pass the original URL, to FreeTube with the freetube:// prefix, instead of mutilating youtu.be ones into broken youtube.com ones. Your current approach of mutilating the URL is clearly causing more issues than it solves.

For yattee you are just swapping out the URL scheme. Why do you feel the need to create broken URLs for FreeTube, when you could just do 'freetube://' + url and not cause problems?

@ManeraKai
Copy link
Member

@absidue
Copy link

absidue commented Sep 26, 2022

That issue mentions problems with the AUR releases of FreeTube which are unofficial and not maintained by the FreeTube team. So bugs specific to those releases should not stop you from fixing libredirect to work with the official FreeTube releases.

Considering that we (FreeTube team) mention libredirect in our README it would be nice if libredirect at least worked with FreeTube. Hopefully there will be a fixed libredirect release soon, would be sad if we had to stop recommending libredirect for FreeTube (no point recommending something to our users, that doesn't work for the one thing we are recommending using it for).

KDash211 pushed a commit to KDash211/extension_browser that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants