-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle youtu.be for Freetube redirect #393
handle youtu.be for Freetube redirect #393
Conversation
Freetube doens't handle case when videoID is just path. Freetube could handle this properly, but its much easier to fix and release this extension I guess.
Thanks! and sorry for being late |
This isn't actually an issue with FreeTube instead it's caused by libredirect passing |
@absidue thanks |
I'll fix that. |
@ManeraKai looks like the code is still broken. this code should work: return `freetube://${url}` |
@absidue Please see - FreeTubeApp/FreeTube#1598 (comment) We are using the right URL. If you face issues, It is already logged and being fixed in v2.3. There's a lot of stuff undergoing changes. Stay tuned 😉 |
@EdwardLangdon As someone who works on FreeTube, please just pass the original URL, to FreeTube with the For yattee you are just swapping out the URL scheme. Why do you feel the need to create broken URLs for FreeTube, when you could just do |
FreeTubeApp/FreeTube#1598 |
That issue mentions problems with the AUR releases of FreeTube which are unofficial and not maintained by the FreeTube team. So bugs specific to those releases should not stop you from fixing libredirect to work with the official FreeTube releases. Considering that we (FreeTube team) mention libredirect in our README it would be nice if libredirect at least worked with FreeTube. Hopefully there will be a fixed libredirect release soon, would be sad if we had to stop recommending libredirect for FreeTube (no point recommending something to our users, that doesn't work for the one thing we are recommending using it for). |
Freetube doens't handle case when videoID is just path (https://youtu.be/XXX) Freetube could handle this properly, but its much easier to fix and release this extension I guess.