Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services: Fix anonymousOverflow redirect when answers are linked #619

Merged

Conversation

brian6932
Copy link
Contributor

@brian6932 brian6932 commented Feb 6, 2023

Currently, if an answer is linked in the url, the url expands to 2 ids, the first one being the thread, and the second being the answer. Anonymous Overflow at the moment, doesn't support linking to answers, you'll just get a 404 page not found, url.hashing doesn't work either (or rather, it doesn't 404, but it doesn't actually link you to the answer), this PR fixes this by grabbing the thread ID directly.
example:
https://stackoverflow.com/a/11227902
https://stackoverflow.com/questions/11227809/why-is-processing-a-sorted-array-faster-than-processing-an-unsorted-array/11227902

@ManeraKai ManeraKai merged commit 617b0da into libredirect:master Feb 6, 2023
@ManeraKai
Copy link
Member

ManeraKai commented Feb 6, 2023

Thanks :) I modified the regex a little bc it was taking the first id number where it should be taking the last id in the path.

@privacytime101
Copy link

Hi @brian6932, thanks for pointing this out. Please feel free to open an issue at the AnonymousOverflow repo for feature requests, it's not very visible here. Thanks for the redirect fix.

CatCoder32 pushed a commit to CatCoder32/extension_browser that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants