Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should no longer be any "niveales" or "wind" in the project, except in application_.xml #52

Closed
libreliodev opened this issue Apr 22, 2013 · 7 comments
Assignees

Comments

@libreliodev
Copy link
Owner

Sub issue of #1

Niveales is the name of of a client, and Wind is the name of a magazine. When customizing the app for other clients and magazines, the magazine name and client name will be different.

Here is an example of code that should be corrected, in order to avoid having any code to change when customizing the app later on:

    try
        {
            manager = new MagazineManager("http://librelio-europe.s3.amazonaws.com/niveales/wind/", "Magazines");

            await manager.LoadPLISTAsync();

            var mag = new List<Item>();
            foreach (var url in manager.MagazineUrl)
            {
                mag.Add(new Item { Title = url.Title, Subtitle = url.Subtitle, FullName = url.FullName });
            }
            itemListView.ItemsSource = mag;
        }
@ghost ghost assigned dd1804 Apr 22, 2013
@dd1804
Copy link
Collaborator

dd1804 commented Apr 23, 2013

I’ve made the change and now the app reads the base url, client name and magazine name from application_xml

De la: libreliodev
Trimis: ‎luni‎, ‎22‎ ‎aprilie‎ ‎2013 ‎12‎:‎08
Către: libreliodev/windows8
Cc: Dorin Damaschin

Sub issue of #1

Niveales is the name of of a client, and Wind is the name of a magazine. When customizing the app for other clients and magazines, the magazine name and client name will be different.

Here is an example of code that should be corrected, in order to avoid having any code to change when customizing the app later on:
try
{
manager = new MagazineManager("http://librelio-europe.s3.amazonaws.com/niveales/wind/", "Magazines");

        await manager.LoadPLISTAsync();

        var mag = new List<Item>();
        foreach (var url in manager.MagazineUrl)
        {
            mag.Add(new Item { Title = url.Title, Subtitle = url.Subtitle, FullName = url.FullName });
        }
        itemListView.ItemsSource = mag;
    }


Reply to this email directly or view it on GitHub.

@libreliodev
Copy link
Owner Author

There is still some code with "wind" and "niveales". This seems to be related with uncompleted #8

           receipt = Uri.EscapeDataString(receipt);
            var productId = "wind_358_";
            url += "?receipt=" + receipt + "&product_id=" + productId + "&urlstring=" + "niveales/wind/wind_358/wind_358_.pdf";

@libreliodev
Copy link
Owner Author

Additionally, it would be more convenient not to add an extra setting called url in Application_.xml, but to use "client_name" and "magazine_name" settings.

@dd1804
Copy link
Collaborator

dd1804 commented Apr 24, 2013

I've removed the url setting. The code with wind is the test scenario page. I will remove it from the project later on, I still use it for some testing.

@libreliodev
Copy link
Owner Author

@dd1804 Is the wind code still needed for the test scenario?

@dd1804
Copy link
Collaborator

dd1804 commented Apr 25, 2013

No, the test scenario is not accesible anymore.

@libreliodev
Copy link
Owner Author

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants