-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There should no longer be any "niveales" or "wind" in the project, except in application_.xml #52
Comments
I’ve made the change and now the app reads the base url, client name and magazine name from application_xml De la: libreliodev Sub issue of #1 Niveales is the name of of a client, and Wind is the name of a magazine. When customizing the app for other clients and magazines, the magazine name and client name will be different. Here is an example of code that should be corrected, in order to avoid having any code to change when customizing the app later on:
— |
There is still some code with "wind" and "niveales". This seems to be related with uncompleted #8
|
Additionally, it would be more convenient not to add an extra setting called url in Application_.xml, but to use "client_name" and "magazine_name" settings. |
I've removed the url setting. The code with wind is the test scenario page. I will remove it from the project later on, I still use it for some testing. |
@dd1804 Is the wind code still needed for the test scenario? |
No, the test scenario is not accesible anymore. |
OK |
Sub issue of #1
Niveales is the name of of a client, and Wind is the name of a magazine. When customizing the app for other clients and magazines, the magazine name and client name will be different.
Here is an example of code that should be corrected, in order to avoid having any code to change when customizing the app later on:
The text was updated successfully, but these errors were encountered: