Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenize default options between FirstBootWizard and lime-defaults #612

Open
ilario opened this issue Oct 4, 2019 · 2 comments
Open

Comments

@ilario
Copy link
Member

ilario commented Oct 4, 2019

adhoc_ssid in FirstBootWizard code and in lime-defaults-factory should be identical and they are not.
See

uci_cursor:set("lime-defaults", 'wifi', 'adhoc_ssid', 'LiMe.%H')

and

I can see no reason for having that line in FirstBootWizard code (and the next about ieee80211s_mesh_id), deleting it may fix.
Additionally, those two lines could break communities setting a custom adhoc_ssid and ieee80211s_mesh_id in their lime-defaults or network-profiles.

@ilario
Copy link
Member Author

ilario commented Jun 5, 2020

The ssid has been homogenized sometimes in the past.
Anyway there are other settings that look different:

uci_cursor:set("wireless", device_name, "mcast_rate", '24000')

option adhoc_mcast_rate_2ghz '24000'
option adhoc_mcast_rate_5ghz '6000'
option ieee80211s_mcast_rate_2ghz '24000'
option ieee80211s_mcast_rate_5ghz '6000'

uci_cursor:set("wireless", device_name, "distance", '1000')

option distance_2ghz '100'
option distance_5ghz '1000'

Can't FBW just take the values from lime-defaults config file instead of having hardcoded ones?

@ilario ilario changed the title Homogenize adhoc_ssid between FirstBootWizard and lime-defaults-factory Homogenize default options between FirstBootWizard and lime-defaults Jun 5, 2020
@ilario ilario moved this from Mid priority - Worth to fix to Low priority - Maybe next release in LibreMesh 2020.2 release Jun 5, 2020
@gmarcos87 gmarcos87 removed their assignment Jun 18, 2020
@spiccinini
Copy link
Contributor

Related to this issue #859

@ilario ilario added this to the 2020.2 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
LibreMesh 2020.2 release
  
Low priority - Maybe next release
LibreMesh 20.xx release
  
Needs triage
Development

No branches or pull requests

3 participants