Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling in check-date-http #723

Closed
ilario opened this issue Jun 9, 2020 · 1 comment · Fixed by #981
Closed

Error handling in check-date-http #723

ilario opened this issue Jun 9, 2020 · 1 comment · Fixed by #981

Comments

@ilario
Copy link
Member

ilario commented Jun 9, 2020

Running check-date-http on a two nodes mesh with no internet connection results in this error:

/usr/bin/lua: /usr/bin/check-date-http:49: attempt to index local 'algo' (a number value)
stack traceback:
	/usr/bin/check-date-http:49: in main chunk
	[C]: ?

this means that checking for the success variable here

if(not success) then
print(arg[0], "HTTP request failed", url, success, response, algo)

is not enough to assure that the connection was good.

@ilario ilario added the bug label Jun 9, 2020
@ilario ilario added this to Needs triage in LibreMesh 2020.2 release via automation Sep 22, 2020
@ilario ilario moved this from Needs triage to Low priority - Maybe next release in LibreMesh 2020.2 release Sep 22, 2020
@ilario
Copy link
Member Author

ilario commented Oct 1, 2020

The solution would be to check if the content of algo['headers']['Date'] is a valid date, and to remove the current check.

@ilario ilario added this to the 2020.2 milestone Feb 28, 2023
LibreMesh 2020.2 release automation moved this from Low priority - Maybe next release to Closed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants