fixed get_valid_macs and ui #45
Conversation
There was a problem hiding this comment.
Hi @luandro. It's a good thing that this repo is activated again!
There I published an observation about obtaining the IP. For future pull-request it is good that the changes are made in smaller and limited commits. Many of the changes made are stylistic, and it is hard to see the substantial differences.
It is a way to make the reviews, and further corrections simpler.
| ubusError = true | ||
| }) | ||
|
|
||
| }) |
There was a problem hiding this comment.
for some reason this block is a little entangled in the viewer, ... can't tell easier what this part of the change is about.
as a suggestion, it easens the review if the changes are organized in commits that tell what the change is about... it makes the reviewer focus on the relation between the commit comment and the commit content, and any issue that could arrise from there...
|
Are we waiting for something to merge this? @nicopace @gmarcos87 |
|
We will merge for now so @luandro can deal with the issue later without stopping the work. |
Hey @gmarcos87 and @nicopace! I'm dedicating this coming week for doing some Pirania work.
This is a first PR that fixes a major problem with the
get_valid_macsfunction which was breaking everything; and also fixes some UI problems that I noticed in many phones.